-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes broken links by leveraging pkgdown
autodetection of function use in inline code
#1435
Conversation
Code Coverage Summary
Diff against main
Results for commit: 4e6d738 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 27 suites 10m 40s ⏱️ Results for commit 4e6d738. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit afa8e18 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found out that https://rstudio.github.io/shiny/reference/moduleServer.html
can be replaced with shiny::moduleServer()
. Does it make sense to do this in this PR?
Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
@gogonzo I noticed that too on the blueprint when searching for -The `teal` framework leverages the [`shiny` module concept](https://rstudio.github.io/shiny/reference/moduleServer.html) to enable encapsulation of analytical actions in `teal` modules, while maintaining seamless communication between the modules and the application.
+The `teal` framework leverages the `shiny` module concept (`shiny::moduleServer()`) to enable encapsulation of analytical actions in `teal` modules, while maintaining seamless communication between the modules and the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Please ignore my comment about moduleServer
Changes description
insightsengineering.github.io/teal/...
tofun_name()
knitr
keeps the inline code as is, so CRAN's vignettes don't have the linksurlcheck
CI doesn't fail onmain
and PRs with unreleased codelatest-tag
Alternatives considered
Using relative links (
../reference
), but this will break CRAN vignettes as well