Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Add support for tag pattern to github_repository_environment_deployment_policy resource #1974

Closed
1 task done
thulasirajkomminar opened this issue Oct 23, 2023 · 1 comment · Fixed by #2165
Closed
1 task done
Labels
Status: Pinned A way to keep old or long lived issues around Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@thulasirajkomminar
Copy link

Describe the need

The resource github_repository_environment_deployment_policy has branch_pattern to add branch based protection so could you also implement the same for tag based pattern. The github API already supports this as type=tag.

https://docs.github.com/en/enterprise-cloud@latest/rest/deployments/branch-policies?apiVersion=2022-11-28#create-a-deployment-branch-policy

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thulasirajkomminar thulasirajkomminar added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Oct 23, 2023
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Oct 23, 2023
@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Oct 23, 2023
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Jul 20, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2024
@github-project-automation github-project-automation bot moved this from 🔥 Backlog to ✅ Done in 🧰 Octokit Active Jul 27, 2024
@kfcampbell kfcampbell reopened this Jul 29, 2024
@kfcampbell kfcampbell added Status: Pinned A way to keep old or long lived issues around and removed Status: Stale Used by stalebot to clean house labels Jul 29, 2024
@kfcampbell kfcampbell moved this from ✅ Done to 🆕 Triage in 🧰 Octokit Active Jul 29, 2024
@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Jul 29, 2024
@github-project-automation github-project-automation bot moved this from 🔥 Backlog to ✅ Done in 🧰 Octokit Active Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pinned A way to keep old or long lived issues around Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
2 participants