Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External price impact warning showing for 0.0% #1531

Open
tomjeatt opened this issue Aug 18, 2023 · 1 comment
Open

External price impact warning showing for 0.0% #1531

tomjeatt opened this issue Aug 18, 2023 · 1 comment

Comments

@tomjeatt
Copy link
Collaborator

Is this right? Feel like we shouldn't be showing it for 0, but maybe an edge case:

Screenshot 2023-08-18 at 13 27 01
@nud3l nud3l added this to Backlog Aug 18, 2023
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog Aug 18, 2023
@peterslany
Copy link
Contributor

I think the problem here is that ETH amount shows as 0 - probably the price is unavailable?

And I guess the calculation of price impact returns 0 in such case. So the question is how do we want to handle case when price of one of the assets is unavailable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New 🆕
Development

No branches or pull requests

2 participants