Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift click ILE selection broken on book page #10246

Open
mheiman opened this issue Jan 1, 2025 · 0 comments · May be fixed by #10247
Open

Shift click ILE selection broken on book page #10246

mheiman opened this issue Jan 1, 2025 · 0 comments · May be fixed by #10247
Assignees
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Bug Something isn't working. [managed]

Comments

@mheiman
Copy link
Collaborator

mheiman commented Jan 1, 2025

Problem

The ILE supports shift-clicking to select a range of elements. Because of a structural change on the book page, this no longer works to select ranges of editions.

Reproducing the bug

  1. While logged in as a librarian, visit a work with multiple editions (e.g. https://openlibrary.org/works/OL63996W/The_Alhambra)
  2. Click the first edition to select it.
  3. Hold down the shift key and click an edition further down the page.
  • Expected behavior: All of the editions between the first and second clicks should be selected.
  • Actual behavior: Only the editions clicked on are selected.

Context

  • Browser (Chrome, Safari, Firefox, etc): Firefox
  • OS (Windows, Mac, etc): Mac
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Breakdown

I will be submitting a PR to fix this shortly.

Stakeholders

@cdrini @mheiman


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@mheiman mheiman added Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Jan 1, 2025
@mheiman mheiman linked a pull request Jan 1, 2025 that will close this issue
@mekarpeles mekarpeles added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Lead labels Jan 6, 2025
@mekarpeles mekarpeles added Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants