As of September 2022 update, Customize UI changes undone on VS Code restart #51

emilyst · 2022-10-06T18:47:18Z

I am still working on confirming that this is a problem with Customize UI or what might have changed, but from several tests, it seems as if restarting VS Code undoes any changes from Customize UI. (Is this a Monkey Patch problem?)

From "Help: About":

Version: 1.72.0
Commit: 64bbfbf67ada9953918d72e1df2f4d8e537d340e
Date: 2022-10-04T23:21:58.256Z (1 day ago)
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 21.6.0
Sandboxed: No

Customize UI version v0.1.65.
Monkey Patch version v0.1.21.

If anyone can reproduce this, please reply? Thanks.

emilyst · 2022-10-06T19:09:02Z

Through more testing, I have confirmed this issue does not occur on VS Code version 1.71.2. Upgrading again causes the issue again. (No extensions were changed during this test.)

I have been reading through the September 2022 milestone but cannot yet find a commit which would cause this new behavior.

ClaudiusSeibt · 2022-10-06T22:10:00Z

Same here! My Title bar styling broke as soon as I opened VS Code. I downgraded both Customize UI and Monkey Patch to privious versions, but this did not work. So I'm assuming VS Code 1.72.0 broke either Monkey Patch or Customize UI.

From "Help: About":

Version: 1.72.0 (Universal)
Commit: 64bbfbf67ada9953918d72e1df2f4d8e537d340e
Date: 2022-10-04T23:21:58.256Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin arm64 21.6.0
Sandboxed: No

Customize UI version 0.1.65
Monkey Patch version 0.1.21

GJRobert · 2022-10-07T06:01:59Z

Thanks to previous reporters for opening this issue.

Here are my current workaround for reference:
Found that UI customizations losing effects? Fine, just touch a little in your

    "customizeUI.stylesheet": {
	...
    },

settings (if you don't have any yet, just write some dumb CSS there), and save settings.json, and reload the window as prompted. Voilà, UI customizations are there again.

But there is one thing I cannot make working: inline titlebar of macOS.
Hopefully this extension can be fixed soon!

knopp · 2022-10-07T11:20:30Z

Can you retry with monkey-patch 0.1.22?

gee-forr · 2022-10-07T11:33:42Z

Can you retry with monkey-patch 0.1.22?

This fixes it!!! Thank you so much. VSCode is so fugly without CustomizeUI. ❤️

hk21702 · 2022-10-07T18:18:36Z

I'm still having issues even with monkey-patch updated to 0.1.22. I've tried stuff like changing the stylesheet slightly, as well as enabling and disabling monkey-patch. Customize UI is on 0.1.65

Any help would be appreciated!

Help About:

Version: 1.72.0 (user setup)
Commit: 64bbfbf67ada9953918d72e1df2f4d8e537d340e
Date: 2022-10-04T23:20:39.912Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: No

knopp · 2022-10-07T18:25:20Z

@hk21702, I think the problem in your case might be that you're running vscode on Windows. There might be a path separator issue with the patch that I didn't realize. I'll try to reproduce the problem.

emilyst · 2022-10-07T18:35:12Z

@hk21702, I think the problem in your case might be that you're running vscode on Windows. There might be a path separator issue with the patch that I didn't realize. I'll try to reproduce the problem.

Nota bene: https://nodejs.org/api/path.html#pathjoinpaths

emilyst · 2022-10-07T23:38:50Z

Confirming this newest version of Monkey Patch fixes the issue for me. Thanks a lot for that.

The cause is probably due to one of these numerous changes to make instantiation of the editor more "lazy." I wonder if Microsoft should implement certain kinds of "hooks" for extensions to use at startup time, assuming they haven't already.

mfreeman-xtivia · 2022-10-08T03:03:34Z

Still broken for me on Windows with version 0.1.22 of monkeypatch installed

sean-codes · 2022-10-08T03:52:15Z

On windows I did a fresh install of VS Code with only Customize UI and it did not work with latest monkeypatch

GJRobert · 2022-10-08T09:30:53Z

Monkey Patch v0.1.22 fixes this issue. Great to see that inline titlebar again!!! Thank you so much @knopp !

gencer · 2022-10-08T10:51:34Z

I really don't like to do +1 comments however, I'm pretty sure -including me- Windows is not fixed. All "fixes" mentioned here seems to be either OSX or Linux.

UPDATE:

v0.1.23 solved issues on Windows. Thanks :) 🥳

mfreeman-xtivia · 2022-10-08T12:15:52Z

v0.1.23 just fixed everything for me on Windows..Thank you !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

sean-codes · 2022-10-08T15:32:35Z

Thank you. v0.1.23 on Windows 11 it is working!

Haruno19 · 2022-10-17T07:29:59Z

CustomizeUI doesn't work anymore for me with MokeyPatch v0.1.23 and VS Code version 1.72.2 (on both MacOS and Windows 11). Don't know if it's still a Monkey Patch problem?

Version: 1.72.2 (Universal)
Commit: d045a5eda657f4d7b676dedbfa7aab8207f8a075
Date: 2022-10-12T22:16:30.254Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin arm64 21.6.0
Sandboxed: No

Everything worked fine a few VS Code updates ago

GJRobert · 2022-10-19T08:07:04Z

CustomizeUI doesn't work anymore for me with MokeyPatch v0.1.23 and VS Code version 1.72.2 (on both MacOS and Windows 11). Don't know if it's still a Monkey Patch problem?

Hi, I'm on VS Code v1.72.2 + Monkey Patch v0.1.23 here, on macOS 11.6, and my CustomizeUI is working fine, with all UI modifications applied, including inline titlebar. Perhaps you have to find a way re-invoke the notification of "Monkey Patch configuration changed" to get correct result again to click that "Re-apply" button on it.

Haruno19 · 2022-10-19T08:45:38Z

That's interesting... I'm on macOS 12.6, I tried changing some settings, like "customizeUI.titleBar" for example, saved the settings.json file but the notification wasn't invoked. I ran the command "Enable Monkey Patch" and it didn't return any error but didn't do anything. I tired disabling and re-enabling both the Monkey Patch and CustomizeUI extensions but that didn't work either, I tried uninstalling and reinstalling them but got the same result. I also installed VScodium instead, installed the extensions and used the same settings.json file but I got the same behaviour: no errors but the changes aren't applied.

If there's anything I can do to help, like attaching some screenshots or settings, let me know

knopp · 2022-10-19T08:47:47Z

If you don't get prompt after changing customizeUI properties it would mean the extension is not loaded properly for some reason. As for VSCodium, the extension is not tested with it so I don't know if it works. I tested both latest insiders and stable version and both seem to work for me.

Haruno19 · 2022-10-19T08:56:33Z

Ok got it. I tried to uninstall and re-install the extension again but it didn't event ask for a reload.
Maybe I am missing some VS Code settings? I have no idea, it worked just fine a few days ago
Can I see VS Code logs somehow?

Here's a video of its current behaviour

GJRobert · 2022-10-20T01:10:28Z

Ok got it. I tried to uninstall and re-install the extension again but it didn't event ask for a reload. Maybe I am missing some VS Code settings? I have no idea, it worked just fine a few days ago Can I see VS Code logs somehow?

Here's a video of its current behaviour

I cannot guarantee that I have found the solution, but maybe you can try making some changes in the custom CSS setting part of CustomizeUI and save the settings.json. See if this works for you.

Also, I encounter the notification of re-apply Monkey Patch configuration every time I open Code, and I can re-apply with success every time. Maybe a "install other versions" of Monkey Patch and install back to the newest version may help too.

Haruno19 · 2022-10-20T06:55:24Z

Thanks for the help!
Unfortunately neither changing the CSS nor installing previous versions for the extensions (and updating it back also) worked.
I'll try downgrade VS Code to an older version to see if that's the problem, otherwise I'll just wait for future updates (both for Monkey Patch and VS Code) that may fix my issue

Update:

So, I installed VS Code version 1.70 from July 2022 (when I'm sure the extensions worked fine for me), downgraded both Customize UI and Monkey Patch in order to make them work with that version of VS Code, but even this time nothing happened, the changes weren't applied and the notification wasn't invoked.

At this point I think it's clear that the problem resides only in my current setup/environment, I don't know what is that causes this behaviour but I'll try to figure it out!

Thanks everyone for your support & help :)

ArturoDent · 2022-12-29T19:14:50Z

See Engineering: private and protected properties are being mangled now.

Could be the cause of this extension's problems lately.

knopp transferred this issue from iocave/customize-ui Oct 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

As of September 2022 update, Customize UI changes undone on VS Code restart #51

As of September 2022 update, Customize UI changes undone on VS Code restart #51

emilyst commented Oct 6, 2022

emilyst commented Oct 6, 2022 •

edited

Loading

ClaudiusSeibt commented Oct 6, 2022

GJRobert commented Oct 7, 2022 •

edited

Loading

knopp commented Oct 7, 2022

gee-forr commented Oct 7, 2022

hk21702 commented Oct 7, 2022 •

edited

Loading

knopp commented Oct 7, 2022

emilyst commented Oct 7, 2022

emilyst commented Oct 7, 2022

mfreeman-xtivia commented Oct 8, 2022

sean-codes commented Oct 8, 2022

GJRobert commented Oct 8, 2022

gencer commented Oct 8, 2022 •

edited

Loading

mfreeman-xtivia commented Oct 8, 2022

sean-codes commented Oct 8, 2022

Haruno19 commented Oct 17, 2022 •

edited

Loading

GJRobert commented Oct 19, 2022

Haruno19 commented Oct 19, 2022 •

edited

Loading

knopp commented Oct 19, 2022

Haruno19 commented Oct 19, 2022 •

edited

Loading

GJRobert commented Oct 20, 2022

Haruno19 commented Oct 20, 2022 •

edited

Loading

ArturoDent commented Dec 29, 2022

As of September 2022 update, Customize UI changes undone on VS Code restart #51

As of September 2022 update, Customize UI changes undone on VS Code restart #51

Comments

emilyst commented Oct 6, 2022

emilyst commented Oct 6, 2022 • edited Loading

ClaudiusSeibt commented Oct 6, 2022

GJRobert commented Oct 7, 2022 • edited Loading

knopp commented Oct 7, 2022

gee-forr commented Oct 7, 2022

hk21702 commented Oct 7, 2022 • edited Loading

knopp commented Oct 7, 2022

emilyst commented Oct 7, 2022

emilyst commented Oct 7, 2022

mfreeman-xtivia commented Oct 8, 2022

sean-codes commented Oct 8, 2022

GJRobert commented Oct 8, 2022

gencer commented Oct 8, 2022 • edited Loading

UPDATE:

mfreeman-xtivia commented Oct 8, 2022

sean-codes commented Oct 8, 2022

Haruno19 commented Oct 17, 2022 • edited Loading

GJRobert commented Oct 19, 2022

Haruno19 commented Oct 19, 2022 • edited Loading

knopp commented Oct 19, 2022

Haruno19 commented Oct 19, 2022 • edited Loading

GJRobert commented Oct 20, 2022

Haruno19 commented Oct 20, 2022 • edited Loading

Update:

ArturoDent commented Dec 29, 2022

emilyst commented Oct 6, 2022 •

edited

Loading

GJRobert commented Oct 7, 2022 •

edited

Loading

hk21702 commented Oct 7, 2022 •

edited

Loading

gencer commented Oct 8, 2022 •

edited

Loading

Haruno19 commented Oct 17, 2022 •

edited

Loading

Haruno19 commented Oct 19, 2022 •

edited

Loading

Haruno19 commented Oct 19, 2022 •

edited

Loading

Haruno19 commented Oct 20, 2022 •

edited

Loading