Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Prop <prop_name> on <>is immutable on <stencil_router_component> #2853

Closed
pranjalworm opened this issue Mar 15, 2021 · 6 comments
Closed

@Prop <prop_name> on <>is immutable on <stencil_router_component> #2853

pranjalworm opened this issue Mar 15, 2021 · 6 comments
Labels

Comments

@pranjalworm
Copy link

Stencil version:

I'm submitting a:

[ x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:
Stencil throws many warnings:-

  • @prop() "history" on is immutable but was modified from within the component
  • @prop() "location" on is immutable but was modified from within the component.
  • @prop() "routeViewsUpdated" on is immutable but was modified from within the component.
  • @prop() "historyType" on is immutable but was modified from within the component.

Expected behavior:
N/A

Steps to reproduce:
The issue is happening on stencil's starter app also.

  1. Follow the steps mentioned here: https://stenciljs.com/docs/getting-started and create an app.
  2. Serve the app and open it in a browser.
  3. You'll the see the above listed warnings.

Related code:

// insert any relevant code here

Other information:

@ionitron-bot ionitron-bot bot added the triage label Mar 15, 2021
@prats8m2
Copy link

I'm also facing this same exact issue.

@Perronef5
Copy link

Perronef5 commented Mar 22, 2021

I'm also facing the same issue. Additionally, some of our components are outputting this as well as soon as I updated to Stencil v2.4.0

@trazek
Copy link

trazek commented Mar 29, 2021

I too am facing this issue

@rafael-leal-mccormack
Copy link

rafael-leal-mccormack commented Mar 29, 2021

Can we add an option in the stencil.config or environment variable that will stop these warnings from showing? I would be willing to PR it myself worst case scenario

@rwaskiewicz
Copy link
Contributor

Hey folks,

I apologize this has taken so long to get looked at. As of earlier this month, we've moved the router to the Stencil Community group. As a result, the Stencil team is no longer maintaining the Stencil router. While these warnings are expected of @Props in Stencil components that are mutated in a component, I believe to properly silence them for the router specifically would require some rework of the router.

I'm going to see if GH will let me move this issue to the new stencil community repo for the router...

@rwaskiewicz
Copy link
Contributor

I'm going to see if GH will let me move this issue to the new stencil community repo for the router...

Hmmm looks like I can't

Note: You can only transfer issues between repositories owned by the same user or organization account. A private repository issue cannot be transferred to a public repository.

I've recreated this issue at stencil-community/stencil-router#139. Please follow that new issue for updates.

@rwaskiewicz rwaskiewicz closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants