Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream changes related to the humble-future branch #15

Open
Flova opened this issue Feb 10, 2023 · 5 comments
Open

Upstream changes related to the humble-future branch #15

Flova opened this issue Feb 10, 2023 · 5 comments

Comments

@Flova
Copy link

Flova commented Feb 10, 2023

As ros2/rclcpp#1979 and ros2/rcl#995 are merged humble-future is not needed anymore for ros rolling.

So humble-future could be the main / rolling branch and a seperate humble branch could be created based of the current main until the changes are backported into humble.

We might want to wait for the package sync.

Or am I missing something?

@Flova Flova changed the title Upstream changes in rclcpp Upstream changes related to the humble-future branch Feb 10, 2023
@alsora
Copy link
Collaborator

alsora commented Feb 10, 2023

That was fast =)
Yes, exactly.

I will cleanup the repo to reflect these changes in the next few days

@russkel
Copy link

russkel commented Mar 9, 2023

There was just a patch release in humble. I don't think those patches were flagged for backporting?

As a side note, do you guys have a rclcpp branch with all the goodies cherry-picked? I did have a look at irobot-ros/rclcpp and there's a lot of patches!

@alsora
Copy link
Collaborator

alsora commented Mar 9, 2023

FYI, we will soon open a PR towards the official rclcpp repo to merge the events-executor there.

Yes, the branch you linked is "our" humble branch.
It contains a lot of bug-fixes cherry-picked from rolling

@russkel
Copy link

russkel commented Mar 9, 2023

Thanks @alsora I will use your rclcpp branch for the time being. I am excited to try out this executor :)

@alsora
Copy link
Collaborator

alsora commented Mar 9, 2023

Note that the rclcpp branch in the iRobot repository may also require some custom rcl/rmw libraries (you can find them among the irobot-ros repositories)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants