Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/start-setupRbac: line 16: isTrue: command not found #2435

Closed
atyrode opened this issue Oct 14, 2023 · 4 comments · Fixed by #2436
Closed

/start-setupRbac: line 16: isTrue: command not found #2435

atyrode opened this issue Oct 14, 2023 · 4 comments · Fixed by #2436
Labels

Comments

@atyrode
Copy link

atyrode commented Oct 14, 2023

if [[ -v APPEND_OPS ]] && isTrue "${APPEND_OPS}"; then
EXISTING_OPS_FILE=MERGE
elif [[ -v OVERRIDE_OPS ]] && isTrue "${OVERRIDE_OPS}"; then
EXISTING_OPS_FILE=SYNCHRONIZE
fi
if [[ -v APPEND_WHITELIST ]] && isTrue "${APPEND_WHITELIST}"; then
EXISTING_WHITELIST_FILE=MERGE
elif [[ -v OVERRIDE_WHITELIST ]] && isTrue "${OVERRIDE_WHITELIST}"; then
EXISTING_WHITELIST_FILE=SYNCHRONIZE
fi
# shellcheck source=start-utils
. "${SCRIPTS:-/}start-utils"
isDebugging && set -x

Hello, I feel like that might be a misuse of something on my side but, start-utils is not "imported" in setupRbac before the first isTrue, and since that's a function that's part of start-utils, I consistently get:

...
[init] Enabling whitelist functionality
[init] Setting mode
[mc-image-helper] 02:53:06.217 INFO  : Created/updated 16 properties in /data/server.properties
/start-setupRbac: line 16: isTrue: command not found <-----------------
[init] Creating log4j2.xml in /data/log4j2.xml
[init] Using Aikar's flags
...

I don't know too much about bash so I'm worried it might not be running the rest of the script?

@itzg
Copy link
Owner

itzg commented Oct 14, 2023

Thanks for reporting this. I had put the import in the wrong spot and apparently hadn't hit those test cases before now.

@itzg itzg added the bug label Oct 14, 2023
@itzg itzg moved this to In progress in Docker Minecraft Oct 14, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Docker Minecraft Oct 14, 2023
@itzg
Copy link
Owner

itzg commented Oct 14, 2023

Should be fixed with this image build https://github.com/itzg/docker-minecraft-server/actions/runs/6520298931

@atyrode
Copy link
Author

atyrode commented Oct 14, 2023

@itzg Thanks a lot. Sincerely.

@itzg
Copy link
Owner

itzg commented Oct 14, 2023

And thanks for the sponsorship!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants