-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to patch default config file spigot.yml
#3211
Comments
Since it is kind of related: Note that I explicitly specified Apart from the bug I reported here, my goal would be to also be able to patch the configuration files |
Sorry, there was too much to read. What's the problem to fix? Are you saying the defaults need to download some to non-config directory? Or are you saying patching seems to be limited to /data/config only? But using an absolute path worked around that? |
Yes.
No, that is not the problem. I just wanted to demonstrate that there is currently no way to patch |
I just merged the workflow stuff in the config repo, this should at least resolve on some versions default configs are not being populated. |
Thanks for clarifying @Krymonota Ok yeah, I see now that I need to have it declare the resulting file name relative to /data yet download from the defaults repo using the flattened path. FYI /data is the volume path and /data/config is just a subdirectory. |
Describe the problem
Currently, it is not possible to patch default configuration files that are supposed to be located outside the
/data/config
directory, such as thespigot.yml
file.The
spigot.yml
file is downloaded as part of the default configuration files:docker-minecraft-server/scripts/start-deployPaper
Lines 46 to 48 in 05cbbfc
Unfortunately, all default configuration files (so even if I add some more by providing the
DOWNLOAD_DEFAULT_CONFIGS
environment variable with additional files) are put in the/data/config
directory:docker-minecraft-server/scripts/start-setupEnvVariables
Lines 30 to 38 in 05cbbfc
However, only the
paper-global.yml
andpaper-world-defaults.yml
files belong to the/data/config
directory. Thespigot.yml
file and all other default configuration files that you may want to patch must be put in the/data
directory, which is not the case at the moment.Container definition
File
patches/spigot.yml.patch.json
:This patch does not work because
/data/spigot.yml
does not exist.File
patches/spigot2.yml.patch.json
:This patch works because the default
spigot.yml
file is put in/data/config
, but it remains there and is not used by the server. Instead, the server generates a new file at/data/spigot.yml
, as can be seen here (checksettings.bungeecord
):Container logs
The text was updated successfully, but these errors were encountered: