-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaks Play Integrity API for some devices (needs to be tested for >v1.15.0) #18
Comments
cant reproduce. even if that was the case i cant fix it. i already did whats possible to not break play integrity. |
It was a weird coincidence I guess... |
I have the same issue, after enabling the module and rebooting the system, the issue with Play Integrity API starts happening, I tried using SPIC and this error shows up: For now, SafetyNet works fine. I'm using a Samsung phone with custom ROM and Magisk. |
Even without reboot, the moment I detach, I get a -100 error. The moment I reattach, the error is gone. In logcat I saw an error with weird characters on the detached package name, my guess is this module breaks the package name in a way that google play does not detect it, making the app detached, but the package name change with weird characters also breaks integrity api call, for some reason. Issue still happens to me. EDIT I don't have much time but, if @j-hc wants it and would like to check this, I can upload the log I'm talking about. |
@j-hc Sorry, still the same, here's the log: Let's see how it goes for @yuzamei2854 |
Hi, forgive me if I'm not able to give useful information, I'm still new to root and Magisk. The problem still persists after the v1.10.0 update, I did the same test as the OP about detach and reattach, and I can confirm that when the application is detached, the error -100 starts to appear, after reattaching the error disappears. As I still don't know how to get logs, I used the same app as the OP, here's a screenshot of a part I suspect from the log. I will try to provide information if necessary. |
probably wont work but try this module: |
I reattached the app, deleted the module, installed this test version and detached the app again, still the same. |
you rebooted after flashing right? what do the logs show now |
Yes, I rebooted after flashing it, here is the logs: |
Hmm, still issues when the package name is not recognized... Is Play Integrity verifying package names?? |
BTW, in case it helps. I'm on MIUI 12 / Android 10 (xiaomi.eu rom). |
@pmsobrado @yuzamei2854 try this one |
@j-hc Still no dice 😩 Same -100 error: |
@pmsobrado how about this one |
It works! How did you do it? |
by using a hackish way to return a fake app's info. it works for you but will crash for other android versions. |
That's weird... I do have Android 10 and MIUI 12, but Play Store version should be the same, or similar to modern phones, right? Why this different behaviour? BTW, the app shows as "disabled" on Play Store, is that a part of the hackish ways? |
because im not hooking play store but libbinder.
yes |
Well, if you need testing, logs or want me to debug something, please ask :) |
Doesn't work, same error. |
Working on Android 9. |
So I guess older versions of Android need different methods... but I still don't get it, isn't Play Store app version the same as on recent phones? Shouldn't this only affect Play Store app, and not anything of the Android system/ROM? |
like i said play store version is irrelevant. zygisk-detach hooks binder driver of the kernel which changes across android versions. |
Yes, don't worry, take all the time you need. I just though you we're binding some Play Store process (on normal versions of your module, not these latest test ones) renaming packages on some db relative to Play Store, without affecting the system. |
I also ran into this problem on Android 9 |
I am getting the same issue, tested with release and all tests versions all break integrity API. |
@N0nd, @MrManinBlack1337, the developer has already said that the test version can't work on every device and he needs time to find a good solution, for now, logs could help the developer. |
actually, the test version helped me, I just reported that I had such a problem. but the test version works well. |
ok i decided on a solution. new test build here: if working fine, i will merge the changes. |
The newest test version works for me, play integrity remained intact! Thank you |
aight merged the changes. closing the issue. |
Works for me too. |
i reverted the fix as it doesnt stop play store from updating detached apps: #37 |
closing the issues as nobody reported anything |
Screenshot of Play Store page of the app you are trying to detach:
Not applicable.
Screenshot of the helper CLI showing detached apps (from Option 2):
Not applicable.
Logs taken with
su -c logcat -s "zygisk-detach" > /sdcard/log.txt
:Not applicable.
I used this module to detach an app. After that, the Play Integrity API request from Play store (in developer tools/options) fails with error -100 (internal error). After trying some stuff I checked logcat, and found an error trying to read the detached app from somewhere, some database I guess. The app had the first two characters modified to unknown ones, which I guess is the method this module uses to detach.
In any case, this seesm to break Play Integrity API request from official Play store app.
The text was updated successfully, but these errors were encountered: