Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new JackTickDouble from 1.9.19 #8

Open
falkTX opened this issue Mar 24, 2022 · 2 comments · May be fixed by #12
Open

Add new JackTickDouble from 1.9.19 #8

falkTX opened this issue Mar 24, 2022 · 2 comments · May be fixed by #12
Assignees
@SpotlightKid
Labels
enhancement New feature or request

Comments

@falkTX
Copy link
Member

falkTX commented Mar 24, 2022

See https://jackaudio.org/news/2021/07/16/jack2-v1919-release.html
The new code is added all in jackaudio/jack2@814629b
@SpotlightKid
Copy link
Collaborator

How would you detect whether the tick_double field is valid at run-time? In Python you can't check for a compile-time definition.

@SpotlightKid SpotlightKid added the enhancement New feature or request label Mar 26, 2022
@SpotlightKid SpotlightKid self-assigned this Mar 26, 2022
@falkTX
Copy link
Member Author

falkTX commented Mar 26, 2022

the macro is only needed in order to make the build succeed, because the headers could be installed system-wide.
using pyjacklib is akin to shipping our own headers, so we can assume for support to be there.

SpotlightKid added a commit that referenced this issue Mar 27, 2022
@SpotlightKid
feat: add support for new 'tick_double' field in 'jack_position_t' (f…
5623966 
…ixes #8)

Signed-off-by: Christopher Arndt <[email protected]>
@SpotlightKid SpotlightKid linked a pull request Mar 27, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SpotlightKid SpotlightKid

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for new 'tick_double' field in 'jack_position_t' (fixes #8) jackaudio/pyjacklib
2 participants
@falkTX @SpotlightKid