Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml2ly: Bar number comments are off by one #2

Open
lemzwerg opened this issue Mar 27, 2024 · 0 comments
Open

xml2ly: Bar number comments are off by one #2

lemzwerg opened this issue Mar 27, 2024 · 0 comments

Comments

@lemzwerg
Copy link

[ef5018a]

Consider the MusicXML file in the attached archive and process it with

xml2ly bar-number-comments.xml > bar-number-comments.ly

There are two issues.

  • The created .ly file contains entries like

    \tuplet 3/2 { b'4 b' b' } r  | % 2
    \barNumberCheck #2

    which is very confusing – a casual reader easily gets the impression that % 2 belongs to the line where it is printed. [LilyPond's musicxml2ly script has exactly the same buglet, BTW.] I suggest to completely remove these comments.

  • At the end of the music input you can find

    \once\slurDashed b'4 ( b' b' )  | % 4
    \barNumberCheck #4

    However, the MusicXML input has only three bars. I strongly suggest to remove both the comment and the call to \barNumberCheck.

bar-number-comments.zip

@lemzwerg lemzwerg changed the title Bar number comments are off by one xml2ly: Bar number comments are off by one Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant