Feature Enabling and Disabling of jaeger-agent #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancasa
requested changes
Oct 4, 2024
iblancasa
approved these changes
Oct 7, 2024
|
You need to regenerate the bundle to make the CI pass. |
Due to deprecation of the jaeger agent, and the fact that jaeger can accept the traces directly via OTEL SDK. I don't know if this change is too simple and will introduce side effects. So please help me Signed-off-by: Magnus Jensen <[email protected]>
Signed-off-by: Magnus Jensen <[email protected]>
Signed-off-by: Magnus Jensen <[email protected]>
Mactherobot
force-pushed
the
feat/2322
branch
from
90810a1 to
b4d8f12
Compare
Signed-off-by: Magnus Jensen <[email protected]>
iblancasa
requested changes
Oct 10, 2024
Signed-off-by: Magnus Jensen <[email protected]>
iblancasa
approved these changes
Oct 10, 2024
|
@iblancasa Is there a way that this can move forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to deprecation of the jaeger agent, and the fact that jaeger can accept the traces directly via OTEL SDK. I don't know if this change is too simple and will introduce side effects. So please help me, if i'm missing anything.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test