RangeError: Maximum call stack size exceeded

[GeoffreyPlitt]

We're using this library to upload video content to twitter tweets on behalf of our users.

Sometimes getting a stack overflow error, from various lines in /src/api-client/stringify.js, any ideas?

Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: /app/node_modules/twitter-media/src/api-client/stringify.js:6
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: return entries(object).reduce((state, [key, value]) => {
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: ^
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: RangeError: Maximum call stack size exceeded
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at entries.reduce (/app/node_modules/twitter-media/src/api-client/stringify.js:6:35)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at Array.reduce (native)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at replaceBuffers (/app/node_modules/twitter-media/src/api-client/stringify.js:6:28)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at stringifyValue (/app/node_modules/twitter-media/src/api-client/stringify.js:12:24)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at entries.reduce (/app/node_modules/twitter-media/src/api-client/stringify.js:18:50)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at Array.reduce (native)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at replaceBuffers (/app/node_modules/twitter-media/src/api-client/stringify.js:6:28)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at stringifyValue (/app/node_modules/twitter-media/src/api-client/stringify.js:12:24)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at entries.reduce (/app/node_modules/twitter-media/src/api-client/stringify.js:18:50)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at Array.reduce (native)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at replaceBuffers (/app/node_modules/twitter-media/src/api-client/stringify.js:6:28)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at stringifyValue (/app/node_modules/twitter-media/src/api-client/stringify.js:12:24)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at entries.reduce (/app/node_modules/twitter-media/src/api-client/stringify.js:18:50)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at Array.reduce (native)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at replaceBuffers (/app/node_modules/twitter-media/src/api-client/stringify.js:6:28)
Jul 16 13:33:16 stardust-backend app/fb_tw_posting.1: at stringifyValue (/app/node_modules/twitter-media/src/api-client/stringify.js:12:24)

[GeoffreyPlitt]

@janzal

[GeoffreyPlitt]

@janzal thoughts?

[janzal]

Hi, stringify is used only when an error during upload occurs (https://github.com/janzal/twitter-media/blob/master/src/api-client/index.js#L103).

@GeoffreyPlitt Can you provide me more info about when the error occurs and maybe some minimal example? Tests seem to be okay and we are using this library in production without any issues.

[janzal]

Can you try this branch: https://github.com/janzal/twitter-media/tree/fix/stringify-buffers?

[GeoffreyPlitt]

Seems to have fixed the error!

[GeoffreyPlitt]

That seems to have fixed this error!