Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client match with location vs history #112

Closed
djeeg opened this issue Aug 1, 2016 · 2 comments
Closed

client match with location vs history #112

djeeg opened this issue Aug 1, 2016 · 2 comments

Comments

@djeeg
Copy link

djeeg commented Aug 1, 2016

routes and location are used here:
https://github.com/jaredpalmer/react-production-starter/blob/master/client/index.js#L33
match({ routes, location }, (error, redirectLocation, renderProps)

in this thread, taion says that routes and history should be used on the client
remix-run/react-router#3290 (comment)

does this cause any problems?

@jaredpalmer
Copy link
Owner

@djeeg I'm honestly not sure of the difference.

Ryan Florence uses location here: https://github.com/ryanflorence/example-react-router-server-rendering-lazy-routes/blob/master/modules/client.js#L12

Feel free to submit a PR if you find a major difference in perf.

@djeeg djeeg closed this as completed Aug 3, 2016
@jaredpalmer
Copy link
Owner

@djeeg did you figure out this issue with redial?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants