Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make x, y, and z trainable #441

Open
michaeldeistler opened this issue Oct 9, 2024 · 0 comments
Open

Make x, y, and z trainable #441

michaeldeistler opened this issue Oct 9, 2024 · 0 comments
Labels

Comments

@michaeldeistler
Copy link
Contributor

michaeldeistler commented Oct 9, 2024

Currently, x, y, and z are listed in nodes but are not trainable. After discussing with @jnsbck, we found a few a few initial issues with making those trainable:

  • How to compute the length from just compartment centers?
  • How to deal with SWC morphologies?
  • How to warn users about compartment ends no longer being connected?

Our proposed solution is to make an offset trainable and rely on the user to define the initial x, y, z:

branch.make_trainable("x_offset")
branch.comp(0).make_trainable("y_offset")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant