Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New distance #451

Open
jnsbck opened this issue Oct 18, 2024 · 1 comment
Open

New distance #451

jnsbck opened this issue Oct 18, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good second issue Can be done without knowing the ins and outs of Jaxley, but probably not suited fo newcomers. v1.0

Comments

@jnsbck
Copy link
Contributor

jnsbck commented Oct 18, 2024

In line with connect I think it might be sensible to move distance out of CompView and to somewhere else such that the following works.

comp1 = jx.Comp()
comp2 = jx.Comp()

distance(comp1,comp2)

Could also assert that they are part of the same Module of course still, i.e. with is_same_network. Also distance should be able to not just compute a distance for a single comp, but also between N <-> N, 1 <-> N or N <-> 1 compartments and return a vector.

EDIT: should be trivial if #447 is merged, since cell.branch(0).comp(0).xyzr works.

@jnsbck jnsbck added enhancement New feature or request good first issue Good for newcomers labels Oct 18, 2024
@michaeldeistler michaeldeistler added good second issue Can be done without knowing the ins and outs of Jaxley, but probably not suited fo newcomers. and removed good first issue Good for newcomers labels Oct 23, 2024
@manuelgloeckler manuelgloeckler self-assigned this Oct 24, 2024
@jnsbck
Copy link
Contributor Author

jnsbck commented Nov 20, 2024

Hey @manuelgloeckler are you still working on this or do you need any help? Would be happy to collab on this as well (incl the graph stuff). Lemme know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good second issue Can be done without knowing the ins and outs of Jaxley, but probably not suited fo newcomers. v1.0
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants