Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make types consistent across Module attributes #454

Open
jnsbck opened this issue Oct 23, 2024 · 0 comments
Open

Make types consistent across Module attributes #454

jnsbck opened this issue Oct 23, 2024 · 0 comments
Labels
good second issue Can be done without knowing the ins and outs of Jaxley, but probably not suited fo newcomers.

Comments

@jnsbck
Copy link
Contributor

jnsbck commented Oct 23, 2024

Some attrs like cumsum_nbranches have different types in different Modules.
Also we should make sure that the attributes are ideally numpy arrays not jax arrays.

fyi @michaeldeistler
@jnsbck jnsbck added good first issue Good for newcomers good second issue Can be done without knowing the ins and outs of Jaxley, but probably not suited fo newcomers. and removed good first issue Good for newcomers labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good second issue Can be done without knowing the ins and outs of Jaxley, but probably not suited fo newcomers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jnsbck