Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URGENT: jit simulate broken #467

Closed
jnsbck opened this issue Oct 24, 2024 · 1 comment · Fixed by #478
Closed

URGENT: jit simulate broken #467

jnsbck opened this issue Oct 24, 2024 · 1 comment · Fixed by #478
Labels
bug Something isn't working high priority

Comments

@jnsbck
Copy link
Contributor

jnsbck commented Oct 24, 2024

The following lines break jitting of simulate + data_set / data_stimulate!

This slipped through the tests!

jaxley/jaxley/modules/base.py

Lines 1156 to 1160 in 61c5c27

if key in self.base.synapse_param_names:
syn_name_from_param = key.split("_")[0]
syn_edges = self.__getattr__(syn_name_from_param).edges
inds = syn_edges.loc[inds.reshape(-1)]["local_edge_index"].values
inds = inds.reshape(-1, 1)

We have to make sure jit simulate with trainable parameters is tested!

run tutorial 07 on 26acd32 to reproduce.

@jnsbck jnsbck added bug Something isn't working high priority labels Oct 24, 2024
@jnsbck
Copy link
Contributor Author

jnsbck commented Oct 24, 2024

Fixed in #453, but still needs tests added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant