Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README renovation #183

Open
rayrrr opened this issue May 23, 2022 · 1 comment
Open

README renovation #183

rayrrr opened this issue May 23, 2022 · 1 comment

Comments

@rayrrr
Copy link
Member

rayrrr commented May 23, 2022

This project's README is currently written in reStructuredText format, which provides for additional functionality that is lacking from Markdown. The main additional functionality used in this project is the ability to introspect code snippets and run unit tests on them (to help ensure valid code examples in documentation).

However, the README contains several links to map visualizations which are sadly no longer active and which we are unable to fix for reasons.

The good news is that GitHub has recently announced native support for GeoJSON map visualizations in GitHub Flavored Markdown (GFM). So, this is the shortest path to adding map visualizations back to the README. Here's an example native GeoJSON Point visualization showing the location of the East River Amphitheater Park in NYC.

{"coordinates": [-73.9778, 40.7111], "type": "Point"}
{"coordinates": [-73.9778, 40.7111], "type": "Point"}
Loading

This new feature is only available for GFM though, not reStructuredText. So, we can have beautiful map visualizations along with each example in the README, or we can introspect and unit test the code snippets for each example in the README, but not both.

Furthermore, from a packaging perspective, GFM has been natively supported by the PyPi renderer just like reStructuredText since 2019, so that is no longer a reason to avoid GFM.

My inclination would be to convert the README to GFM and leverage the map visualization feature, as I feel it would make the documentation more accessible, but I want a sense of community support for this.

If you think sacrificing unit-tested code snippets for built-in GeoJSON map visualizations in the README is a good idea, please give this issue a thumbs up. If you disagree, thumbs down. And of course, comment with any pertinent thoughts.

Thank you!

@rayrrr
Copy link
Member Author

rayrrr commented May 24, 2022

After thinking this over a bit more, I'm hoping there's a solution that, with minimal added complexity, will allow us to have the best of both worlds. If we can parse the code examples in reStructuredText to unit test them, then in theory, we should also be able to parse the code examples to run them, and then geojson.dumps the output of each, and then programmatically generate a markdown file that visualizes all examples in a way that is guaranteed to stay in sync even if the code snippets change, all as part of the CI process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant