Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libudev-compat: fcntl definitions missing on older glibc #62

Open
tilt12345678 opened this issue Sep 2, 2015 · 1 comment
Open

libudev-compat: fcntl definitions missing on older glibc #62

tilt12345678 opened this issue Sep 2, 2015 · 1 comment

Comments

@tilt12345678
Copy link
Contributor

building libudev-compat fails on amd64 libc 2.13 (wheezy) with
MAX_HANDLE_SZ undefined
struct file_handle resolves to incomplete type
this is just jused for the definition of file_handle_union, which in turn appears not to be used in libudev-compat.
i got it to compile anyhow by adding the missing definitions according to a libc version 2.19 fcntl bits/fcntl-linux.h see 7104a1b for details
hooray ;-) but probably it was smarter to just delete the offending code

@jcnelson
Copy link
Owner

jcnelson commented Sep 2, 2015

Heh, this is because libudev-compat was forked from systemd's libudev 219, so it doesn't surprise me that there are bits that won't compile on Wheezy. If you send me your diff as a PR I'd be happy to merge it :).

In general, I'm in favor of making changes like the one you proposed instead of removing code, since I'd like to keep libudev-compat's code as close as possible to libudev's. This makes it easier for me to keep libudev-compat's API in sync with libudev's.

jcnelson pushed a commit that referenced this issue Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants