Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 给个默认背景色,解决在小程序中固定列与滚动内列混合 #2766

Closed
wants to merge 1 commit into from

Conversation

kid-kang
Copy link
Contributor

@kid-kang kid-kang commented Nov 18, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

Issue链接

💡 需求背景和解决方案

  • 在飞书小程序中使用Table左固定列,活动内容时,表格内容会与固定列内容混合
  • 原因是固定列的背景色默认为空,则会透视层叠之下的内容
  • 解决办法就是给固定列加一个不透明的背景色 如:#fff

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新功能
    • 为固定表头单元格添加了默认背景颜色,改善了表格的视觉效果。

Copy link

coderabbitai bot commented Nov 18, 2024

Walkthrough

此次更改主要涉及在table.scss文件中为.nut-table组件的粘性表头单元格添加默认背景颜色。具体而言,在.nut-table-main-head-tr-th选择器中添加了一行代码,设置了.nut-table-fixed-left.nut-table-fixed-right类的background-color#fff。此修改旨在解决小程序中固定列与可滚动内列混合在一起导致的视觉问题。

Changes

文件路径 更改摘要
src/packages/table/table.scss .nut-table-main-head-tr-th添加background-color: #fff;,适用于.nut-table-fixed-left.nut-table-fixed-right类。

Possibly related issues

Possibly related PRs

  • refactor: table #2473: 此PR涉及对Table组件渲染逻辑的重大修改,可能与PR中关于粘性表头单元格样式的更改相关。

Suggested labels

3.x

Suggested reviewers

  • oasis-cloud

Poem

🐇 在表格中跳跃,背景变白,
固定列清晰,内容不再混淆。
小程序里,视觉更美好,
兔子欢跳,庆祝这变化妙! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 3.x label Nov 18, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
src/packages/table/table.scss (1)

77-78: 背景色设置方案评审

代码变更解决了小程序中固定列内容重叠的问题,实现方案合理。不过建议将背景色值抽取为 SCSS 变量,以便统一管理和维护主题。

建议修改为:

- background-color: #fff;
+ background-color: $table-fixed-column-bg-color;

然后在变量文件中定义:

$table-fixed-column-bg-color: #fff !default;
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6213d88 and a8ec292.

📒 Files selected for processing (1)
  • src/packages/table/table.scss (1 hunks)

@xiaoyatong
Copy link
Collaborator

可以在 2.x 上提一个。就是提给 next 分支。

@kid-kang kid-kang closed this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants