-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 给个默认背景色,解决在小程序中固定列与滚动内列混合 #2766
Conversation
Walkthrough此次更改主要涉及在 Changes
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/packages/table/table.scss (1)
77-78
: 背景色设置方案评审代码变更解决了小程序中固定列内容重叠的问题,实现方案合理。不过建议将背景色值抽取为 SCSS 变量,以便统一管理和维护主题。
建议修改为:
- background-color: #fff; + background-color: $table-fixed-column-bg-color;然后在变量文件中定义:
$table-fixed-column-bg-color: #fff !default;
可以在 2.x 上提一个。就是提给 next 分支。 |
🤔 这个变动的性质是?
🔗 相关 Issue
Issue链接
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit