-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeouts may not be upheld #299
Comments
I'm having this problem |
What are you experiencing? |
I've been using your TMDBLib library for the last few years and it has been very good for me in that long period, but in the last few weeks the GetMovieAsync, GetTvShowAsync, DiscoverMoviesAsync and DiscoverTvShowsAsync methods (I only use these at the moment) have been slow in responses and sometimes returns null values, I still can not investigate why this is occurring but I believe it is related to the http request, it gets stuck for a long time even if X-RateLimit is OK |
Hmm. Certainly sounds like it. The result of the method is null? If it's an error code of sorts, and the result is null - we should probably throw exceptions instead.. Feel like we've been over this before :O. Would you like a timeout for the entire request, or a timeout for reading and writing, or something else entirely? |
It's come to my attention that the Timeouts given to HttpClient (CancellationTokens) only apply to the actual request, and up till the response is "ready". Once the response is being read (as a Stream), the timeouts no longer apply.
We should ensure that our Timeouts work.
The text was updated successfully, but these errors were encountered: