Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External MPV in flatpak #417

Open
lowne opened this issue Sep 30, 2024 · 0 comments
Open

External MPV in flatpak #417

lowne opened this issue Sep 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@lowne
Copy link

lowne commented Sep 30, 2024

Regarding the numerous issues on running external mpv from flatpak - eg #375 #354 #329 #80 and #76 (indirectly) - is there any reason why flatpak-spawn --host /path/to/mpv can't be used internally? This can't be done by the end user because mpv_ext_path is passed as is and ultimately used as the binary path (as opposed to split into a List[str] then further extended with the other args).

This will need:

  • figuring out when we're being run within the sandbox (surely there's a sanctioned way but perhaps just checking for flatpak-spawn could do it), and if so prepending flatpak-spawn --host to the command
  • adding the relevant permission (org.freedesktop.Flatpak D-Bus interface)
  • possibly adding a filesystem permission for the socket/tempfile

or alternatively, allow it from conf.json; passing a list by ' '.split(mpv_ext_path) will most likely break on windows so maybe add an alternative mpv_ext_cmd field:

  "mpv_ext": true,
  "mpv_ext_path": "",
  "mpv_ext_cmd": ["flatpak-spawn", "--host", "/path/to/mpv"],
@lowne lowne added the enhancement New feature or request label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant