Make printing log of "Downloaded <filename> from <server>" optional

[Dmitry1987]

What feature do you want to see added?

To allow disabling the log printed about every single file in a repository (possibly a multi-million files monorepo, like what we use plastic for) in order to not crash Jenkins browser page 😄.
The plugin prints all filenames that it downloads, making log of any large repo to be a mess (plus actually does crash the browser page in chrome for example, if we try to view that page which contains millions of lines about each file 'successfully downloaded from plastic server').
This log is not useful at all, and is really a debug or trace level information. Users should be able to disable printing that.

Upstream changes

not sure what's upstream, but this should be fairly simple, since it only affects verbosity of what's printed in Jenkins log page. Summarizing it as "N number of files were downloaded from server" by default, would make sense for most people IMHO.

[SRombautsU]

Hello,

Thanks for taking the time to provide feedback!
It's a very valid concern, indeed. And in fact I remember that log verbosity was discussed internally, probably after another user made a similar remark.

If this issue is important for you, I would advise you to contact the support team, providing additional info on your setup. First, they might be able to help quickly, but else they will help raise the priority of the issue and follow on it internally.

Sébastien

[Dmitry1987]

most likely it will be a feature request to the CLI team instead? I just realized that the Java plugin uses my 'cm' cli installed on jenkins nodes after all, so it can't control the log level of the cli command if such log level does not exist in it?
how does it run the download step by default, which flags are supplied? if you could point me to the code, I will submit a PR, in case a flag for "--quiet" mode or something like that, exists in the 'cm' command that the plugin use.

[Dmitry1987]

it would be best to simply configure log level globally in the main jenkins settings where the path to local cm command is, maybe passing a flag here could work? is there a '--quiet' flag?
Btw there's an error here if I click on 'help' icon it can't load help text, look:

[mig42]

Hi @Dmitry1987, thanks for your feedback! There's indeed a --silent flag available to the cm switch or cm setselector commands that we could add or toggle according to a config setting.

Regarding the issue with the config help, we'd need to look into it. Thanks for letting us know!

[Dmitry1987]

that would be great, is it a simple change to allow such toggle, making 'on/off' the verbose log? let's say current will remain the default, but a checkbox will do '--silent', for those who have massive numbers of files in repo like we do.

…

On Sat, Jun 10, 2023 at 3:50 PM Miguel ***@***.***> wrote: Hi @Dmitry1987 <https://github.com/Dmitry1987>, thanks for your feedback! There's indeed a --silent flag available to the cm switch or cm setselector commands that we could add or toggle according to a config setting. Regarding the issue with the config help, we'd need to look into it. Thanks for letting us know! — Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACHPL6EUVWSS6TZ7LHKQCTTXKQYNXANCNFSM6AAAAAAY3ILM6A> . You are receiving this because you were mentioned.Message ID: ***@***.***>