Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP API should be split off from Docker-SSH #17

Open
jeroenpeeters opened this issue Oct 11, 2016 · 1 comment
Open

HTTP API should be split off from Docker-SSH #17

jeroenpeeters opened this issue Oct 11, 2016 · 1 comment

Comments

@jeroenpeeters
Copy link
Owner

Currently Docker-SSH comes with an HTTP API and a web client. This invalidates the 'single-responsibility' concept. Docker-SSH does not only bridge the ssh session with a shell started through docker exec, but implements an HTTP API that exposes the shell over an unsecured channel.

Furthermore, the authentication mechanisms implemented for SSH do not apply to the HTTP API. The API, when enabled, simply by-passes these security settings. This makes this channel very insecure.

I propose to remove the HTTP API and the web client from docker-ssh and re-implement it on top of Docker-SSH. This ensures that ssh security is respected and will not be by-passed when configured.
The API and the web client need to implement the appropriate authentication and security measures.

@rleins
Copy link

rleins commented Jul 3, 2017

Anything new on this?

Since I want to use the web-feature as my main access path, i would be very expectant waiting for some Auth_Mechanism on the HTTP API.

thx in advance...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants