-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 Release: NFT + code cleaning + doc update and other improvements. #722
Conversation
…jsartoolkit5-NFT # Conflicts: # three.js/examples/test-runner.html
…jsartoolkit5-NFT # Conflicts: # three.js/experiments/deadreckoning.html
…ting-jsartoolkit5-NFT
We are almost there! I think that two enhancements can be added in the future, not in v3 release:
Actually it works defining it on three.js or aframe side. |
Issue to be added for NFT AFTER release:
|
…ble again, but still content not in right position
Wow v3 seems really close to being released. A week is a good estimate? Can't wait for this! Mate, this will cover like 90% of all AR use cases! I can say goodbye to zappar, 8thwall, awe, vuforia, easyar, arcore, arkit. Well, except when I need world tracking, facetracking. superimposition...but those are the 10% arjs won't cover. |
Could be a good estimate :) |
Yeah it seems that we are on the way! Maybe not a week but we are very optimistic. I'm also very happy, for all the effort that me and @nicolocarpignoli have spent on this, and i hope you all will make awesome project with it!! |
@Marcus5234 and all following this PR, check also this other PR #742 probably this will be the final and definitive Pr with the working code. |
closing, please refer to: #742 |
From #674 (comment) #674 and #705
What kind of change does this PR introduce?
This PR want to test the new jsartoolkit5 from kalwalt/jsartoolkit5#1 with the new changes especially the NFT part.
🖼 This will eventually make AR.js capable of detect and track 2D images.
https://twitter.com/nicolocarp/status/1204841439160684549
Could be raise some bugs and incompatibilties between the code. It is more a test...
Can it be referenced to an Issue? If so what is the issue # ?
From jsartoolkit5 repo: PR kalwalt/jsartoolkit5#1
From AR.js issues:
also, a repo cleaning will help for: #433
How can we test it?
Just test the examples and tell us what happens...
Summary
Does this PR introduce a breaking change?
Nope, it will remove old code, but unnecessary. It will add NFT feature.
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Other information
I uploaded the new jsartookit5 libs and build the AR.js libs with makefile.
Progress