Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Mark 'todo' tests as 'skipped' #242

Open
liamjones opened this issue Feb 3, 2023 · 5 comments · May be fixed by #261
Open

Feature Request: Mark 'todo' tests as 'skipped' #242

liamjones opened this issue Feb 3, 2023 · 5 comments · May be fixed by #261
Labels
enhancement

Comments

@liamjones
Copy link

Currently, if you have a todo test:

it.todo('test not written yet')

It shows up as as success in the XML report:

<testcase classname="" name="test not written yet" time="0">
</testcase>

It feels like these should show the same as it.skip tests, skipped in the XML (since I don't believe there's any way of marking something as todo/pending in the XML schema)
@palmerj3
Copy link
Collaborator

Is the fact that it shows up as a passing test causing a problem on your end?

@liamjones
Copy link
Author

Not as far as things failing to work, no. Only insofar as it feels like its misleading to say "test not written yet" passed.

@palmerj3
Copy link
Collaborator

Yeah I tend to agree. I think I'd be open to either not having them in the report at all, or shown as skipped.

Feel free to submit a PR and I'll review! Otherwise I'll get to this soon.

@maaarghk maaarghk linked a pull request Oct 6, 2023 that will close this issue
Open
@work933k
Copy link

work933k commented Sep 5, 2024

I think this issue should be marked as resolved.

@liamjones
Copy link
Author

liamjones commented Sep 23, 2024 •
edited
Loading

@work933k why? The issue still exists and the PR that potentially fixes it isn't merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mark "todo" tests as skipped maaarghk/jest-junit
3 participants
@palmerj3 @liamjones @work933k