-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip partially hidden under mouse #444
Comments
Hi @sparrowt! Thanks for the specific report w/ screenshot! I think the relevant code to change is here: https://github.com/jlfwong/speedscope/blob/main/src/views/hovertip.tsx, and in particular If the font size in general is a problem, you can use browser zoom (focus the URL bar, and hit ctrl/cmd-+) You can find information on contributing a fix here: https://github.com/jlfwong/speedscope/blob/main/CONTRIBUTING.md |
Fixes jlfwong#444 For context: the default cursor on Windows 10 is 16px wide. Most OSes allow you to make it much bigger so there's not necessarily a 'right' value here, but it feels sensible to at least avoid obscuring it when using defaults. Given most cursors display _below_ the pixel at which the cursor is pointing, a solution which works in more cases would probably need to make a change from the current decision to `// Place the tooltip below the cursor` but for now I have avoided doing this (I'm not sure of the historical reasons) and instead done the minimal improvement.
Thanks for such a useful tool!
One slight issue is the tooltip seems to show up directly under the mouse which can end up obscuring key information such as the duration or amount of memory, for example this is what I see:
How many MB were allocated in that stack?
<something>.11
but I find myself having to move my head very close to the screen to actually read it!A simple offset would hopefully mitigate this for most default mouse cursors.
The text was updated successfully, but these errors were encountered: