From 131d84e1f1aa2e888978adaedd6876b61cd9e2ce Mon Sep 17 00:00:00 2001
From: jm33-m0 <jm33@jm33.me>
Date: Wed, 19 Jul 2023 18:31:56 +0900
Subject: [PATCH] fix: `label` by tag not working

---
 core/lib/cc/cmd.go | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/core/lib/cc/cmd.go b/core/lib/cc/cmd.go
index 495476ede..5f79e124f 100644
--- a/core/lib/cc/cmd.go
+++ b/core/lib/cc/cmd.go
@@ -250,7 +250,7 @@ func setCurrentTarget(cmd string) {
 func setTargetLabel(cmd string) {
 	cmdSplit := strings.Fields(cmd)
 	if len(cmdSplit) < 2 {
-		CliPrintError("Invalid command %s, usage: 'label <target tag/index> <label>'", strconv.Quote(cmd))
+		CliPrintError("Invalid command %s, usage: 'label <tag/index> <label>'", strconv.Quote(cmd))
 		return
 	}
 	target := new(emp3r0r_data.AgentSystemInfo)
@@ -259,18 +259,19 @@ func setTargetLabel(cmd string) {
 	// select by tag or index
 	index, e := strconv.Atoi(cmdSplit[1])
 	if e != nil {
+		// try by tag
 		target = GetTargetFromTag(cmdSplit[1])
-		if target != nil {
-			Targets[target].Label = label // set label
-			labelAgents()
-			CliPrintSuccess("%s has been labeled as %s", target.Tag, label)
-		} else {
-			CliPrintError("cannot set target label by index: %v", e)
+		if target == nil {
+			// cannot parse
+			CliPrintError("Cannot set target label by index: %v", e)
 			return
 		}
+	} else {
+		// try by index
+		target = GetTargetFromIndex(index)
 	}
-	// by index
-	target = GetTargetFromIndex(index)
+
+	// target exists?
 	if target == nil {
 		CliPrintError("Target does not exist")
 		return