Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decomposition inside holes #2

Open
Nish160 opened this issue Mar 16, 2018 · 4 comments
Open

Decomposition inside holes #2

Nish160 opened this issue Mar 16, 2018 · 4 comments

Comments

@Nish160
Copy link

Nish160 commented Mar 16, 2018

I tried running approximate convex decomposition algorithm on my input dataset with 1 out polygonal chain and 1 in polygonal chain(hole) , but the output doesn't respects the holes and also partitions inside the holes.
sample output:
poly_in

I have checked the order of all polygonal chains to be counterclockwise.I have also tried experimenting with all the command line options (-t, -m, -a, -b). What can be the possible reason for this??
I am using Ubuntu 16.04LTS 64 bit.
@jmlien
Copy link
Owner

jmlien commented Mar 16, 2018

Can you share the polygon?

@Nish160
Copy link
Author

Nish160 commented Mar 17, 2018

This is the main input polygon data that I am working on:
trial_poly.txt

@wzmBeiJing
Copy link

Can you share the polygon?

Hi,do you have the latest version? i have the same problem as Nish160 got .

afrixs added a commit to afrixs/acd2d that referenced this issue Nov 20, 2019
@afrixs
more crash fixes:
97f4e76 
findDependency error fix
fixed collision finding on a duplicated vertex
This closes jmlien#2
@afrixs
Copy link

afrixs commented Nov 20, 2019

Hi, actually the inner polygonal chains should be clockwise, because they will turn counterclockwise when connected to the outer polygon. However other problems arise after changing the order of points, but I fixed them right now in my fork (also created a pull request, so hopefully the fixes will be merged soon into this repository).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jmlien @afrixs @wzmBeiJing @Nish160