Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate sync and backup notification types (successes separated from failures) #1325

Open
4 tasks done
FibreTTP opened this issue Nov 18, 2024 · 2 comments
Open
4 tasks done

Comments

@FibreTTP
Copy link

Describe your suggested feature

I have syncing enabled with Syncyomi, syncing automatically every time the app is opened, a chapter is opened or read, and every thirty minutes. Each time one of these occurs, a notification is shown.

Since a sync has never failed, I don't know if it would appear in a separate notification channel, but I assume it doesn't, given the name of the channel (simply, "Progress"). This means I cannot disable notifications for sync successes, without also being unaware of when a sync fails.

Presumably, this also applies to backups and restores, given that syncs are in the same notification category; I don't want to give up the ability to know when a backup fails in order to disable the constant "Syncing library complete" notification.

To go further, this should then also apply to backup and restores, having backup successes and failures be separate notification channels.

Other details

Related: #1152
Maybe related: #1280

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have updated the app to version 1.11.0.
  • I will fill out all of the requested information in this form.
@wedsa5
Copy link

wedsa5 commented Dec 24, 2024

Came here to suggest this feature request. My phone basically has a persistent Syncyomi notification with how often it happens. I also dont want to completely disable all Syncyomi notifications in case there is a failure.

IMO, the notification categories should be as such:

  1. Backup and restore
    1. Allow notifications
    2. Complete
    3. Errors
    4. Progress
  2. Sync
    1. Allow notifications
    2. Complete
    3. Errors
    4. Progress

@wedsa5
Copy link

wedsa5 commented Dec 24, 2024

I have very little experience with Android dev, but it seems it should be a relatively simple change.

  • A few additions to app/src/main/java/eu/kanade/tachiyomi/data/notification/Notifications.kt for the new group and channels.
  • Then some changes to app/src/main/java/eu/kanade/tachiyomi/data/sync/SyncNotifier.kt to use the new channels/group.
  • And if a new channel is created for backup errors, an update to app/src/main/java/eu/kanade/tachiyomi/data/backup/BackupNotifier.kt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants