Unable to rename files

[Alarid]

I have a little script that I wrote and which aims to do the following :

• Runs in a directory with loads of MDX files names like this : "section-01.mdx", "section-02.mdx", and so on
• Takes a section number as argument
• Remove the corresponding file
• Rename all the following sections to fill the gap created (example: if I remove section 2, section 3 becomes section 2, section 4 becomes section 3, and so on

For some reason, the mv command isn't working. I tried with the full file paths, and with just the file names, none are working. The console logs are showing the right operations, the section to be removed is effectively removed, but the other sections are not renamed. I also tried to chmod 777 on all files in case it was an issue with the files permissions, still not working.

Here is the code, any help appreciated as always :

// Exclude: true

import "@johnlindquist/kit"

function buildSectionFilename(index: number) {
  return `section-${index < 10 ? `0${index}` : index.toString()}.mdx`
}

const currentPath = cwd()
const lessonFiles = await readdir(currentPath)
if (!lessonFiles.includes("index.md")) {
  console.log("❌ Not in a lesson directory")
  // TODO also check MD attributes
  exit(1)
}

const sections = lessonFiles.filter((file) => file.startsWith("section-"))
const index = Number(await arg("Section to remove:"))
if (!index || index < 1 || index > sections.length) {
  console.log("❌ Invalid section index")
  exit(1)
}

// Remove the section
const section = sections[index - 1]
const sectionPath = path.join(currentPath, section)
await rm(sectionPath)
console.log("✅ Removed section: " + section)

// Rename all sections following the index
for (let i = index; i < sections.length; i++) {
  const section = sections[i]
  const newSectionId = i
  const newSectionFilename = buildSectionFilename(newSectionId)
  mv(section, newSectionFilename)
  console.log("- Renamed section: " + section + " -> " + newSectionFilename)
}

[johnlindquist]

@Alarid So I thought I'd take a stab at the idea before reading your solution just in case the way I approach it would be helpful:

// Name: Section Manager

import "@johnlindquist/kit"

let sectionPath = home("dev", "testing-section-manager")

let files = await readdir(sectionPath)

if (files.length === 0) {
  let count = 20
  for await (let i of _.range(count)) {
    let fileName = `section-${i.toString().padStart(2, "0")}.mdx`
    let filePath = path.resolve(sectionPath, fileName)

    await writeFile(filePath, `# Section ${i}`)
  }
  files = await readdir(sectionPath)
}

let selectedFile = await arg("Select file to remove", files)
let selectedFilePath = path.resolve(sectionPath, selectedFile)
await rm(selectedFilePath)

files = await readdir(sectionPath)
// Determine which files > than the removed file need to be renamed
let filesToRename = files.filter(file => {
  let fileNumber = parseInt(file.split("-")[1])
  let selectedFileNumber = parseInt(selectedFile.split("-")[1])
  return fileNumber > selectedFileNumber
})

// debug filesToRename
let yn = await arg(
  {
    placeholder: "Rename files down one?",
    hint: `[y]es/[n]o`,
  },
  filesToRename
)

if (yn === "y") {
  // Rename the files down one
  for await (let file of filesToRename) {
    // You could also try "rename" if mv doesn't work for you
    // let { rename } = await import("fs/promises")
    // await rename(
    mv(
      path.resolve(sectionPath, file),
      path.resolve(
        sectionPath,
        file.replace(/\d+/, match => {
          let number = parseInt(match)
          return (number - 1).toString().padStart(2, "0")
        })
      )
    )
  }

  files = await readdir(sectionPath)
  await arg(
    "Verify files have been renamed",
    files.map(f => {
      return {
        name: f,
        preview: async () => {
          return md(await readFile(path.resolve(sectionPath, f), "utf8"))
        },
      }
    })
  )
}

I'm not sure in your solution that mv is respecting the cwd. I would recommend using the full file paths.

You can try using cd(currentPath), but I'm thinking cd is using zx's cd and not shelljs's cd, so I'll need to investigate if that's not working for you.

I personally never use the shelljs mv. I default to zx, exec, or the built-in node helpers.

await $`mv myfile.text`

or the built-in node helpers.

[Alarid]

Thanks for your reply John ! I tried using the full paths as arguments to mv, I also tried with rename, await $mv ..., exec, ... nothing seems to be working, not sure I understand why 🤔

[johnlindquist]

@Alarid Does this work for you?

// Name: Testing Touch and Rename

import "@johnlindquist/kit"

await $`touch ~/testing-rename.txt`
await $`mv ~/testing-rename.txt ~/rename-success.txt`

[Alarid]

Yes it does, thank you ! I'll rewrite my script with this syntax