Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass easy_thumbnails alias to cropped_thumbnail tag #48

Open
rhymes opened this issue Jul 1, 2014 · 3 comments
Open

Pass easy_thumbnails alias to cropped_thumbnail tag #48

rhymes opened this issue Jul 1, 2014 · 3 comments
Assignees

Comments

@rhymes
Copy link

rhymes commented Jul 1, 2014

I understand that it is possible to use easy_thumbnails 'thumbnail' tag instead of 'cropped_thumbnail' like showed here https://django-image-cropping.readthedocs.org/en/latest/#frontend but it would be nice if cropped_thumbnail accepted a registered easy_thumbnails alias too.

Something like

{% cropped_thumbnail yourmodelinstance "ratiofieldname" alias=alias_name %}

See here https://github.com/SmileyChris/easy-thumbnails/blob/master/easy_thumbnails/templatetags/thumbnail.py#L82

@anrie
Copy link
Member

anrie commented Jul 2, 2014

Sounds like a good addition.
There's already a branch (simple_tag) for simplifying the cropped_thumbnail tag.
We should clean that up first, but then it shouldn't be too hard to add the alias option

@rhymes
Copy link
Author

rhymes commented Jul 3, 2014

@anrie do you think it's doable on master?

I'll have to study the code a little

@anrie
Copy link
Member

anrie commented Jul 5, 2014

Hey @rhymes,
of course it should be doable.
But as we currently rework the template tag for the next release i think it's simply not worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants