Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Develop energy-normalization so spectrogram robustly detects rhythmicity #942

Open
asoplata opened this issue Nov 15, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@asoplata
Copy link
Collaborator

No description provided.

@asoplata asoplata added the enhancement New feature or request label Nov 15, 2024
@asoplata asoplata added this to the 0.4 milestone Nov 15, 2024
@asoplata
Copy link
Collaborator Author

@ntolley Dylan mentioned his recollection that we discussed this being part of the v0.5 release (estimated late Spring 2025) instead of the v0.4 release ("soon", in the beginning of 2025). Should this issue be changed to target v0.5?

@asoplata asoplata modified the milestones: 0.4, 0.5 Nov 26, 2024
@asoplata
Copy link
Collaborator Author

Question @ntolley @dylansdaniels : will this allow spectrogram-plotting of our shorter, default ERP simulation in the GUI? I ask because currently, y'all agreed that the spectrogram NOT plotting for the default GUI simulation is expected behavior (see #937 (comment) ). However, in our ERP tutorial (here https://jonescompneurolab.github.io/hnn-tutorials/coregui_erp/coregui_erp.html ), which uses the default GUI simulation settings, there is a specific section "4.3 Viewing ERP Spectrograms" about these spectrograms. Currently, these plots will not be generated for reasons in the first link. Whatever changes Nick derives to our spectral analysis, I think we should probably ensure it works in the shorter ERP case as well.

@dylansdaniels
Copy link
Collaborator

Good catch! I think we can safely remove that section from the tutorial. It's really just there to show off the GUI functionality, but it's not important or relevant for that tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants