Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip processing for Vite virtual resources #146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip processing for Vite virtual resources #146

wants to merge 1 commit into from

Conversation

nextmat
Copy link

@nextmat nextmat commented Jun 11, 2024 •
edited
Loading

We can't process these, so skip them. Run the check prior to the regex match as it should be the quicker of the two operations.

Fixes #142

@nextmat
Skip processing for virtual resources
fe2bca1 
We can't process these, so skip them. Run the check prior to the regex
comparison as it should be faster.
@nextmat nextmat mentioned this pull request Jun 11, 2024
Open
@nextmat nextmat changed the title Skip processing for virtual resources Skip processing for Vite virtual resources Jun 11, 2024
@reslear
Copy link

reslear commented Aug 30, 2024

@jpkleemans pls merge

@reslear
Copy link

reslear commented Sep 4, 2024 •
edited
Loading

here is path:

vite-svg-loader.patch

@nextmat
Copy link
Author

nextmat commented Sep 11, 2024 •
edited
Loading

Just bumping this, any chance of getting this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gracefully handle Vite virtual files
2 participants
@nextmat @reslear