Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker ignores readOnly #4470

Open
4 of 11 tasks
APop123 opened this issue Dec 2, 2024 · 3 comments · May be fixed by #4495
Open
4 of 11 tasks

DatePicker ignores readOnly #4470

APop123 opened this issue Dec 2, 2024 · 3 comments · May be fixed by #4495
Assignees
Labels
component: date picker package: lab Lab package status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working

Comments

@APop123
Copy link

APop123 commented Dec 2, 2024

Latest version

  • I have tested the latest version

Description

Adding readOnly to a DatePicker renders the field as readonly, but the calendar button still appears, and the user can still change the date.

Steps to reproduce

    <DatePicker
      selectionVariant="single"
      readOnly
    >
      <DatePickerTrigger>
        <DatePickerSingleInput />
      </DatePickerTrigger>
      <DatePickerOverlay>
        <DatePickerSinglePanel />
      </DatePickerOverlay>
    </DatePicker>

Expected behavior

User should not be able to change the date

Package name(s)

Lab (@salt-ds/lab)

Package version(s)

1.0.0-alpha.56

Browser

  • Chrome
  • Safari
  • Firefox
  • Microsoft Edge

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@APop123 APop123 added status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working labels Dec 2, 2024
@mark-tate mark-tate self-assigned this Dec 6, 2024
@mark-tate
Copy link
Contributor

Should be in our next release

red Eye : review/release by EOS

@github-actions github-actions bot linked a pull request Dec 13, 2024 that will close this issue
@dplsek
Copy link

dplsek commented Dec 16, 2024

Requires status updated from @mark-tate

@joshwooding
Copy link
Contributor

This will be released in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: date picker package: lab Lab package status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

5 participants