Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Bootcamp] Project 1 - Review my app #1

Open
jreive opened this issue Feb 28, 2016 · 3 comments
Open

[Android Bootcamp] Project 1 - Review my app #1

jreive opened this issue Feb 28, 2016 · 3 comments

Comments

@jreive
Copy link
Owner

jreive commented Feb 28, 2016

I hope it isn't too late ._.
/cc @codepathreview

@chug2k
Copy link

chug2k commented Feb 29, 2016

/cc @coderschoolreview

@coderschoolreview
Copy link

Thank you for your Android submission, nghethihieu!

👏 Everything looks good with the format of your submission. We'll be reviewing your submission soon!

@hoanle
Copy link

hoanle commented Feb 29, 2016

hi @nghethihieu

Thanks for your submission

In general:

  • The app works fine without any critical issue (such as crash)
  • Required features are done

Details & Suggestion:

  • There are several places that can be improved. Optional features such as custom adapter, SQLite database are the suggestions that make your app better. You could improve the app basing on them
  • You should keep reference to the view which you use many time. For example, in onAddItem function , the view etNewItem does not need to be grasped every time you need it. Put it globally and use it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants