Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for VS2022 #19

Open
kgfly opened this issue Nov 21, 2021 · 10 comments
Open

Please add support for VS2022 #19

kgfly opened this issue Nov 21, 2021 · 10 comments

Comments

@kgfly
Copy link

kgfly commented Nov 21, 2021

My box has both VS19 and VS22 installed. But ace-jump cannot detect VS22 during the installation, etc

image

Thanks

@jsturtevant
Copy link
Owner

I no longer work with VS but I am willing to accept a PR

@kgfly
Copy link
Author

kgfly commented Nov 30, 2021

Sorry, I don't know how to do that. Let's see if some one can help out or not.

@kgfly
Copy link
Author

kgfly commented Nov 30, 2021

VS2019 is a x86 exe while VS2022 is a x64 exe. I am not sure how much impact on the plugin.

@kgfly
Copy link
Author

kgfly commented Dec 4, 2021

Hi @jsturtevant , following VS19 support commit, 5fb1a14,

I made some change #20.

But it does not work, etc
image

Do you know why it does not work?

@AaronMaria
Copy link

Try the release in my Fork:
https://github.com/AaronMaria/ace-jump/releases/tag/v1.5
It should work with Visual Studio 2022

@kgfly
Copy link
Author

kgfly commented Dec 7, 2021

Hi @AaronMaria , I tried to build your branch. But it does not work. May you please fix the build failure?

@AaronMaria
Copy link

Hi @kgflying, I assume it was an issue with the references, I think I fixed it, can you pull the latest version and try again?
If it still doesn't work, please tell me the error message you receive.

@jsturtevant
Copy link
Owner

Thanks for all the effort here, if it works could we get #20 updated so we can get an official release out?

@kgfly
Copy link
Author

kgfly commented Dec 30, 2021

Thanks, guys. I found another more powerful plugin and it already has VS22 support, msomeone/PeasyMotion#24

I will switch to that plugin and unsubscribe this thread. Please feel free to close this thread if needed.

Thanks again.

@andy505050
Copy link

Try the release in my Fork: https://github.com/AaronMaria/ace-jump/releases/tag/v1.5 It should work with Visual Studio 2022

It works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants