Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate different string encodings #6

Open
jtracey opened this issue Nov 1, 2022 · 0 comments
Open

Investigate different string encodings #6

jtracey opened this issue Nov 1, 2022 · 0 comments
Labels
cli Improvements or fixes in the CLI lib Improvements or fixes in the library

Comments

@jtracey
Copy link
Owner

jtracey commented Nov 1, 2022

The library punts on string encodings right now, since AFAIK there's no way to know a priori what encoding is being used, and just represents everything as bytes. I think the way you're supposed to get it is with info charset_internal and info charset_terminal, but it's not clear to me how you're supposed to use those without knowing what encoding they're in. Is everything actually just in UTF-8? We need to set up some non-UTF-8 WeeChat relays to test it out.

The CLI is currently written entirely assuming UTF-8. If non-UTF-8 commands or messages are possible, we should support those in the CLI. If everything is actually UTF-8, we should change the types in the library to represent that.
@jtracey jtracey added lib Improvements or fixes in the library cli Improvements or fixes in the CLI labels Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Improvements or fixes in the CLI lib Improvements or fixes in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtracey