Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle newlines in descriptions #521

Open
marcovandeveen opened this issue Apr 25, 2024 · 1 comment
Open

Handle newlines in descriptions #521

marcovandeveen opened this issue Apr 25, 2024 · 1 comment

Comments

@marcovandeveen
Copy link
Member

image
image

@marcovandeveen marcovandeveen changed the title Handle newlines Handle newlines in descriptions Apr 25, 2024
@ChristiaanScheermeijer
Copy link
Collaborator

ChristiaanScheermeijer commented May 31, 2024

We have opened a PR (#538) related to this because the UI breaks when the video description is very long. On mobile devices, we collapse the text, but this causes the layout to shift. On desktop browsers, the buttons were pushed outside the viewport, but because we put the focus on the start-watching button, the page scrolls a bit down.

Because of this, we figured the description shown in the video details should be limited to X characters. The description is limited to X lines to keep the UI intact on desktop browsers.

For Symphony, we use separate fields for this. One for the synopsis (short description shown below the video title) and the description for the full (markdown) about tab below the hero.

image

Therefore, I think we shouldn't support linebreaks in the current description but explore a similar approach to the above screenshot. When the description is placed below the hero, we don't have this limitation and can support markdown rendering with line breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants