Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker check warnings #11474

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix docker check warnings #11474

merged 1 commit into from
Dec 18, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

  • Fix the warnings around Dockerfile syntax

Types of Changes

Internal Build

Verification

docker build . --check -f Dockerfile.local
docker build . --check -f Dockerfile.test

Testing

Linked Issues

N/A

User-Facing Change


Further Comments

I finally broke down and got annoyed enough about these useless warnings.

Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola requested a review from a team as a code owner December 17, 2024 20:17
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.22%. Comparing base (bb32254) to head (bde988b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11474      +/-   ##
==========================================
- Coverage   47.87%   43.22%   -4.66%     
==========================================
  Files         181      181              
  Lines       18794    18794              
==========================================
- Hits         8998     8124     -874     
- Misses       8448     9470    +1022     
+ Partials     1348     1200     -148     
Flag Coverage Δ
e2etests 35.48% <ø> (-7.56%) ⬇️
inttests 18.73% <ø> (-16.13%) ⬇️
unittests 14.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 83a3e85 into k3s-io:master Dec 18, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants