Install script can't install on immutable OS (Fedora Atomic)

[ruzko]

Environmental Info:
K3s Version:
v1.28.5

Node(s) CPU architecture, OS, and Version:
Linux fedora 6.6.14-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Fri Jan 26 20:12:16 UTC 2024 x86_64 GNU/Linux

Cluster Configuration:
1 laptop, where I'm trying to set up dev environment

Describe the bug:

The oneliner on the k3s.io website fails, with the following error:

• yum is not available

This is because Fedora Atomic variants use rpm-ostree, like coreos does.

Steps To Reproduce:

• Installed K3s: using the oneliner on the project website.

Expected behavior:

Fedora Kinoite and other Atomic variants of Fedora are treated more like coreos by the installer script.
There are differences between coreos and Fedora Atomic variants, but the use of rpm-ostree is mostly the same.

Actual behavior:

Fedora Atomic variants are treated like regular fedora.
These variants have neither yum or dnf available, so the install script fails.

Additional context / logs:

os-release for Kinoite:

cat /etc/os-release
NAME="Fedora Linux"
VERSION="39.20240205.0 (Kinoite)"
ID=fedora
VERSION_ID=39
VERSION_CODENAME=""
PLATFORM_ID="platform:f39"
PRETTY_NAME="Fedora Linux 39.20240205.0 (Kinoite)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:39"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://kinoite.fedoraproject.org"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora-kinoite/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://pagure.io/fedora-kde/SIG/issues"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=39
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=39
SUPPORT_END=2024-11-12
VARIANT="Kinoite"
VARIANT_ID=kinoite
OSTREE_VERSION='39.20240205.0'

[ruzko]

Until Fedora standardizes around a VARIANT and/or VARIANT_ID in /etc/os-release for the different atomic desktop variants; a solution could be to change line 518 in the install script from
elif [ "${ID_LIKE:-}" = coreos ] || [ "${VARIANT_ID:-}" = coreos ]; then
to
elif [ "${ID_LIKE:-}" = coreos ] || [ "${VARIANT_ID:-}" = coreos || [ "${VARIANT_ID:-}" = kinoite || [ "${VARIANT_ID:-}" = silverblue || [ "${VARIANT_ID:-}" = onyx || [ "${VARIANT_ID:-}" = sericea ]; then

[brandond]

That is horrid and I don't think I'd want to do that. We already have too many ID/VARIANT values in the script.

[ruzko]

That's a fair assessment. Shall we just wait for Fedora to settle on a common VARIANT and/or VARIANT_ID then?

[brandond]

Yeah, I think that's probably what I'd ask for.

[github-actions]

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 45 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.

[cfraz89]

Just got bitten by this issue with Silverblue.

Could it be a sensible approach, instead of checking for a range of variants for fedora, to just check for ID = "fedora" and OSTREE_VERSION != "" ?

[brandond]

We don't officially support this distro, so we're not going to test it. We just need to confirm that it still works on supported fedora variants.

Reopening so that it can be officially closed out as community validated by QA.

[mdrahman-suse]

Performed validation on Fedora 41 with v1.31.2+k3s1 and Fedora 39 with v1.28.15+k3s1
Observed the installation went through successfully
Will also validate other supported OS's as part of November 2024 Patch Validation

# cat /etc/os-release
NAME="Fedora Linux"
VERSION="39 (Server Edition)"

# k3s -v
k3s version v1.28.15+k3s1 (869dd4d6)
go version go1.22.8

# kubectl get nodes
NAME                                     STATUS   ROLES                       AGE     VERSION
xxx-xx-xxx-56.ip.linodeusercontent.com   Ready    control-plane,etcd,master   5m13s   v1.28.15+k3s1

# kubectl get pods -A
NAMESPACE     NAME                                      READY   STATUS      RESTARTS   AGE
kube-system   coredns-559656f558-7tkv5                  1/1     Running     0          5m6s
kube-system   helm-install-traefik-8tm2q                0/1     Completed   1          5m6s
kube-system   helm-install-traefik-crd-hbd5z            0/1     Completed   0          5m6s
kube-system   local-path-provisioner-7677785564-j4cq6   1/1     Running     0          5m6s
kube-system   metrics-server-7cbbc464f4-wdk8b           0/1     Running     0          5m6s
kube-system   svclb-traefik-6cdcc509-gqmtq              2/2     Running     0          4m57s
kube-system   traefik-6c7b69cd74-dd7tz                  1/1     Running     0          4m57s

# cat /etc/os-release
NAME="Fedora Linux"
VERSION="41 (Server Edition)"

# k3s -v
k3s version v1.31.2+k3s1 (6da20424)
go version go1.22.8

# kubectl get nodes
NAME                                      STATUS   ROLES                       AGE   VERSION
xxx-xx-xxx-168.ip.linodeusercontent.com   Ready    control-plane,etcd,master   68s   v1.31.2+k3s1

# kubectl get pods -A
NAMESPACE     NAME                                      READY   STATUS      RESTARTS   AGE
kube-system   coredns-56f6fc8fd7-zg6p8                  1/1     Running     0          70s
kube-system   helm-install-traefik-8qblm                0/1     Completed   1          70s
kube-system   helm-install-traefik-crd-5wtlk            0/1     Completed   0          70s
kube-system   local-path-provisioner-5cf85fd84d-9tssv   1/1     Running     0          70s
kube-system   metrics-server-5985cbc9d7-hh6t2           0/1     Running     0          70s
kube-system   svclb-traefik-2a072cd7-zx54z              2/2     Running     0          62s
kube-system   traefik-57b79cf995-lrmss                  1/1     Running     0          62s