Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default route selection annotation will require update to admission controller #29

Open
dougbtv opened this issue Oct 16, 2019 · 0 comments

Comments

@dougbtv
Copy link
Member

dougbtv commented Oct 16, 2019

While testing updates to Multus, I encountered this one:

[centos@kube-singlehost-master multus-cni]$ cat <<EOF | kubectl create -f -
> apiVersion: v1
> kind: Pod
> metadata:
>   name: samplepod
>   annotations:
>     k8s.v1.cni.cncf.io/networks: '{
>       "name": "macvlan-conf",
>       "default-route": ["192.168.2.1"]
>     }'
> spec:
>   containers:
>   - name: samplepod
>     command: ["/bin/bash", "-c", "trap : TERM INT; sleep infinity & wait"]
>     image: dougbtv/centos-network
> EOF
Error from server: error when creating "STDIN": admission webhook "net-attach-def-admission-controller-isolating-config.k8s.io" denied the request: parsePodNetworkAnnotation: failed to parse pod Network Attachment Selection Annotation JSON format: json: cannot unmarshal object into Go value of type []*types.NetworkSelectionElement

Looks like we'll need to update this to account for that field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant