Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "error" to "notice" in "spec is not a valid network config list: error parsing ..." #44

Open
dougbtv opened this issue Aug 5, 2021 · 1 comment

Comments

@dougbtv
Copy link
Member

dougbtv commented Aug 5, 2021

Example, this is actually admitted:

I0805 14:32:25.409571       1 webhook.go:117] validating network config spec: { "cniVersion": "0.4.0", "type": "egress-router", "name": "egress-router-cni-nad", "ip": { "addresses": [ "fd2e:6f44:5dd8::64/64" ], "destinations": ["80 TCP 2607:f8b0:4004:808::200e","8080 TCP 2600:1408:20:c81::3831 80","8888 TCP 2001:420:1101:1::185 80"],
"gateway": "fe80::5054:ff:feb0:6560" }, "log_file": "/tmp/egress-router-log", "log_level": "debug" }
I0805 14:32:25.410002       1 webhook.go:141] spec is not a valid network config list: error parsing configuration list: no 'plugins' key - trying to parse into standalone config
I0805 14:32:25.410209       1 webhook.go:154] AdmissionReview request allowed: Network Attachment Definition '{"cniVersion":"0.4.0","ip":{"addresses":["fd2e:6f44:5dd8::64/64"],"destinations":["80 TCP 2607:f8b0:4004:808::200e","8080 TCP 2600:1408:20:c81::3831 80","8888 TCP 2001:420:1101:1::185 80"],"gateway":"fe80::5054:ff:feb0:6560"},"log_file":"/tmp/egress-router-log","log_level":"debug","name":"egress-router-cni-nad","type":"egress-router"}' is valid

So it shouldn't say error, just a notice (if anything at all)

@dougbtv
Copy link
Member Author

dougbtv commented May 5, 2022

$ grep -Prin "error parsing configuration list" *

docs/installation.md:99:I1212 13:47:47.918067       1 webhook.go:79] spec is not a valid network config list: error parsing configuration list: no name - trying to parse into standalone config
docs/installation.md:103:I1212 13:48:25.173233       1 webhook.go:79] spec is not a valid network config list: error parsing configuration list: no 'plugins' key - trying to parse into standalone config
vendor/github.com/containernetworking/cni/libcni/conf.go:65:		return nil, fmt.Errorf("error parsing configuration list: %s", err)
vendor/github.com/containernetworking/cni/libcni/conf.go:70:		return nil, fmt.Errorf("error parsing configuration list: no name")
vendor/github.com/containernetworking/cni/libcni/conf.go:74:		return nil, fmt.Errorf("error parsing configuration list: invalid name type %T", rawName)
vendor/github.com/containernetworking/cni/libcni/conf.go:82:			return nil, fmt.Errorf("error parsing configuration list: invalid cniVersion type %T", rawVersion)
vendor/github.com/containernetworking/cni/libcni/conf.go:95:		return nil, fmt.Errorf("error parsing configuration list: no 'plugins' key")
vendor/github.com/containernetworking/cni/libcni/conf.go:99:		return nil, fmt.Errorf("error parsing configuration list: invalid 'plugins' type %T", plug)
vendor/github.com/containernetworking/cni/libcni/conf.go:102:		return nil, fmt.Errorf("error parsing configuration list: no plugins in list")

This looks like it's coming from libcni, so it's plausible we should just remove our logging for this condition.

nicklesimba pushed a commit to nicklesimba/net-attach-def-admission-controller that referenced this issue Nov 11, 2022
…sistency-openshift-4.11-ose-multus-admission-controller

Updating ose-multus-admission-controller images to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant