Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to ES5 instead of ES6 standard in the NFT examples #27

Closed
kalwalt opened this issue Jan 10, 2020 · 3 comments
Closed

Switching to ES5 instead of ES6 standard in the NFT examples #27

kalwalt opened this issue Jan 10, 2020 · 3 comments
Assignees
@kalwalt
Labels
code design javascript all about javascript code NFT nft markerless technology
Milestone
merging NFT to ar...

Comments

@kalwalt
Copy link
Owner

kalwalt commented Jan 10, 2020

As pointed in this comment #1 (comment) we should switch to ES5 standard.
If you find other code that use ES6 standard please leave me a note here.
@kalwalt kalwalt added javascript all about javascript code code design NFT nft markerless technology labels Jan 10, 2020
@kalwalt kalwalt self-assigned this Jan 10, 2020
@kalwalt kalwalt changed the title Switching to ES5 instead of ES5 standard in the NFT examples Switching to ES5 instead of ES6 standard in the NFT examples Jan 10, 2020
@nicolocarpignoli
Copy link
Collaborator

done with 2103d75

if it's ok for you we can close this one :)

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 10, 2020

@nicolocarpignoli only one last thing: i commented in the code and after it is ok.

@kalwalt
Copy link
Owner Author

kalwalt commented Jan 10, 2020

Perfect! we can close this now.

@kalwalt kalwalt closed this as completed Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalwalt kalwalt

Labels
code design javascript all about javascript code NFT nft markerless technology
Projects
None yet
Milestone
merging NFT to artoolkitx/jsartoolkit...
Development

No branches or pull requests
2 participants
@kalwalt @nicolocarpignoli