-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing nft #1
Fixing nft #1
Conversation
… make the example work again
…ri, as .ogg was not supported by Safari
Merge branch 'typescript' into ts-fromCommunity * typescript: threejs integration fix getMarker return type ARMarkerInfo class update type defs update versıon and publish export necessary modules for typescript type defs for artoolkit.api # Conflicts: # build/artoolkit.debug.js
Merge branch 'typescript' into ts-fromCommunity * typescript: threejs integration fix getMarker return type ARMarkerInfo class update type defs update versıon and publish export necessary modules for typescript type defs for artoolkit.api # Conflicts: # build/artoolkit.debug.js
Ts from community
add setDefaultMarkerWidth
Trackable registration bug
Fixed issue with artoolkit.setup not a function Fixed runtime error Commit new compiled files
Added tests for wasm support Documented how wasm can be used
Webassembly support
@nicolocarpignoli @ThorstenBux we should transform the ES6 syntax used in some nft examples to the ES5 standard. i think it's a bit confusing. I have nothing in contrary in rispect to ES6 standard but there are good reasons to avoid to use: |
Api doc improvements and deleted old documentation in the Readme.md
We could had an error handling at the end of the getUserMedia function: navigator.mediaDevices.getUserMedia( hint ).then( function( stream ) {
// video code
}).catch(function(err) {
console.log(err.name + ": " + err.message);
}); inside the nft examples, |
This was merged in the https://github.com/artoolkitx/jsartoolkit5 master branch ! Probably i will close this PR. |
@kalwalt Yes I think we can merge this one in the 'master' branch of your jsartoolkit5. The missing checklist points will be handled elsewhere :) |
@nicolocarpignoli my master is already in sync with the latest form artoolkitx/jsartoolkit5 i can't merge this PR into my master because there are no other commits, so i will simply close. |
Hi @kalwalt @nicolocarpignoli @ThorstenBux. Hope you all are doing well. Great work guys. Congratulations!!! I tested your examples. Remaining 4 scripts which are:
All gives common error which is: Uncaught SyntaxError: Unexpected end of input and additionally, main.html also throws : main.js:108 Uncaught ReferenceError: ARCameraParam is not defined Please help guys. |
@manojahuja11 i opened an issue #35, i will check when i have time. |
My goal is to make a stable NFT branch;
FS not defined
issuetest and make it works the emscripten compilation also for Windows.For anyone interested to try and to build the lib:
The jsartoolkit is based on the emscripten compiler, you need to install it in your machine, follow these instructions: https://emscripten.org/docs/getting_started/downloads.html. i used emscripten
1.38.31
1.38.44-fastcomp1.39.5-fastcomp. Read this issue #11 regardingemscripten. We not recommend to use emscripten directly but instead use Docker as described in the Readme.md in this chapter recommended-build-using-docker
Testing page
https://kalwalt.github.io/jsartoolkit5/examples/