Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: RemoteAliasesRegistry, RemoteAliasResolver, and RemoteRepositoryRegistry should exist only in CLI layers #985

Open
zaychenko-sergei opened this issue Dec 10, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request rust Pull requests that update Rust code

Comments

@zaychenko-sergei
Copy link
Contributor

zaychenko-sergei commented Dec 10, 2024

Depends on #981

Remote aliases and remote repositories are purely a CLI feature, and on today there are no plans to build any Web UI or Node equivalent. Still, they historically got deeply interrelated with some of the core services, which are not specific to CLI, such as:

  • pull request planner & pull dataset use case
  • push request planner & push dataset use case
  • setting watermarks service

In addition, the information on pull and push aliases is directly attached to ODF dataset representation (info repo, config object), which is breaking portability expectations. It's also unprepared to handle transactionality, esp. when attaching aliases at the end of operations that did not commit changes to the database yet.

TODO in this ticket:

  • move all processing that works with remote references to CLI commands level
  • we may have CLI-level services that are injected in commands, as an example
  • organize CLI-specific storage for dataset pull/push aliases:
    • it could work as separately stored workspace file/files (but outside ODF repository)
    • it could be stored in CLI-specific SQlite database tables

Note: attaching pull & push aliases after succesful syncs can be done in commands or via outbox consumers, specific to CLI

@zaychenko-sergei zaychenko-sergei added enhancement New feature or request rust Pull requests that update Rust code labels Dec 10, 2024
@zaychenko-sergei zaychenko-sergei self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

1 participant