From 318ff9465b3397feb0efbc0bd63d0339b516ddc0 Mon Sep 17 00:00:00 2001 From: Sergei Zaychenko Date: Thu, 28 Nov 2024 15:19:23 +0200 Subject: [PATCH] Type corrected in feature flags --- CHANGELOG.md | 5 ++++- src/app/app-config.model.ts | 2 +- src/app/app.component.ts | 2 +- src/app/auth/login/login.component.spec.ts | 2 +- src/app/components/app-header/app-header.component.spec.ts | 2 +- .../data-access-modal/data-access-modal.component.ts | 2 +- .../dataset-settings-component/dataset-settings.component.ts | 4 ++-- src/assets/runtime-config.json | 2 +- 8 files changed, 12 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d5535439..87a5f2a5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Readme section: modified 'Run' button into a link - Hint extension for tile widget account +### Fixed +- Typo in feature flags (enableDatasetEnvVarsManagement) + ^ ## [0.31.0] - 2024-11-22 ### Added @@ -143,7 +146,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added - Added access token feature - Added environment variables and secrets for the dataset -- Added new flag(enableDatasetEnvVarsManagment) in the runtime configuration +- Added new flag(enableDatasetEnvVarsManagement) in the runtime configuration ### Fixed - Fixed bug with cache(Data tab) on the deployment version - Extended full source info for EthereumLogs(Metadata tab) diff --git a/src/app/app-config.model.ts b/src/app/app-config.model.ts index db1983f5..eac271a0 100644 --- a/src/app/app-config.model.ts +++ b/src/app/app-config.model.ts @@ -21,7 +21,7 @@ export enum LoginMethod { export interface AppConfigFeatureFlags { enableLogout: boolean; enableScheduling: boolean; - enableDatasetEnvVarsManagment: boolean; + enableDatasetEnvVarsManagement: boolean; enableTermsOfService: boolean; } diff --git a/src/app/app.component.ts b/src/app/app.component.ts index db8daa1f..1ecf68fc 100644 --- a/src/app/app.component.ts +++ b/src/app/app.component.ts @@ -40,7 +40,7 @@ export class AppComponent extends BaseComponent implements OnInit { public static readonly DEFAULT_FEATURE_FLAGS: AppConfigFeatureFlags = { enableLogout: true, enableScheduling: true, - enableDatasetEnvVarsManagment: true, + enableDatasetEnvVarsManagement: true, enableTermsOfService: true, }; diff --git a/src/app/auth/login/login.component.spec.ts b/src/app/auth/login/login.component.spec.ts index 5d3d3bfb..636e94f3 100644 --- a/src/app/auth/login/login.component.spec.ts +++ b/src/app/auth/login/login.component.spec.ts @@ -42,7 +42,7 @@ describe("LoginComponent", () => { const MOCK_FEATURE_FLAGS = { enableLogout: true, enableScheduling: true, - enableDatasetEnvVarsManagment: true, + enableDatasetEnvVarsManagement: true, enableTermsOfService: true, }; diff --git a/src/app/components/app-header/app-header.component.spec.ts b/src/app/components/app-header/app-header.component.spec.ts index e543c9d9..3aba1a60 100644 --- a/src/app/components/app-header/app-header.component.spec.ts +++ b/src/app/components/app-header/app-header.component.spec.ts @@ -86,7 +86,7 @@ describe("AppHeaderComponent", () => { component.featureFlags = { enableLogout: true, enableScheduling: true, - enableDatasetEnvVarsManagment: true, + enableDatasetEnvVarsManagement: true, enableTermsOfService: true, }; component.loginMethods = [LoginMethod.GITHUB, LoginMethod.PASSWORD]; diff --git a/src/app/components/data-access-panel/data-access-modal/data-access-modal.component.ts b/src/app/components/data-access-panel/data-access-modal/data-access-modal.component.ts index ea682ca2..5947d8da 100644 --- a/src/app/components/data-access-panel/data-access-modal/data-access-modal.component.ts +++ b/src/app/components/data-access-panel/data-access-modal/data-access-modal.component.ts @@ -42,7 +42,7 @@ export class DataAccessModalComponent { public get showApiTokensLink(): boolean { return ( - this.appConfigService.featureFlags.enableDatasetEnvVarsManagment && + this.appConfigService.featureFlags.enableDatasetEnvVarsManagement && this.loggedUserService.isAuthenticated && this.datasetBasics.kind === DatasetKind.Root ); diff --git a/src/app/dataset-view/additional-components/dataset-settings-component/dataset-settings.component.ts b/src/app/dataset-view/additional-components/dataset-settings-component/dataset-settings.component.ts index 0b7b650a..71aaf8fc 100644 --- a/src/app/dataset-view/additional-components/dataset-settings-component/dataset-settings.component.ts +++ b/src/app/dataset-view/additional-components/dataset-settings-component/dataset-settings.component.ts @@ -66,7 +66,7 @@ export class DatasetSettingsComponent extends BaseComponent implements OnInit { public get showSecretsManagerTab(): boolean { return ( - this.appConfigService.featureFlags.enableDatasetEnvVarsManagment && + this.appConfigService.featureFlags.enableDatasetEnvVarsManagement && this.activeTab === SettingsTabsEnum.VARIABLES_AND_SECRETS ); } @@ -104,7 +104,7 @@ export class DatasetSettingsComponent extends BaseComponent implements OnInit { return this.datasetBasics.kind === DatasetKind.Root; case SettingsTabsEnum.VARIABLES_AND_SECRETS: return ( - this.appConfigService.featureFlags.enableDatasetEnvVarsManagment && + this.appConfigService.featureFlags.enableDatasetEnvVarsManagement && this.datasetBasics.kind === DatasetKind.Root ); default: diff --git a/src/assets/runtime-config.json b/src/assets/runtime-config.json index 6dd81cc4..0131cdc4 100644 --- a/src/assets/runtime-config.json +++ b/src/assets/runtime-config.json @@ -6,7 +6,7 @@ "featureFlags": { "enableLogout": true, "enableScheduling": true, - "enableDatasetEnvVarsManagment": true, + "enableDatasetEnvVarsManagement": true, "enableTermsOfService": true }, "grafanaLogs": {