Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct reddened model band fluxes #135

Open
karllark opened this issue Dec 31, 2024 · 0 comments · May be fixed by #137
Open

Correct reddened model band fluxes #135

karllark opened this issue Dec 31, 2024 · 0 comments · May be fixed by #137
Labels
enhancement New feature or request

Comments

@karllark
Copy link
Owner

The current reddened model band fluxes are computed by applying the extinction to the unreddened band fluxes at the effective/pivot wavelength. This is an approximation and is done to speed up the fitting.

The fully correct reddened band fluxes should be computed by applying the extinction to the model spectra and then integrating over the band response functions. This requires a model spectrum that covers the entire band response function, yet the model spectra used in the fitting are only those where there are observed spectra in the fitting. What is needed is to have a fairly low resolution spectrum over the full wavelength range of possible photometric bands that is used for this calculation.

What is needed:

  1. Saving of the appropriate resolution spectrum over the full possible photometric wavelength range (e.g., 912 A to 32 micron at least).
  2. Reading in these spectra into the fit model object
  3. Reading in the band response functions for the observed bands
  4. Code to apply the extinction to these spectra and integrate over the appropriate band response functions
@karllark karllark added the enhancement New feature or request label Dec 31, 2024
@karllark karllark linked a pull request Jan 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant